gok add: don't add packages that are already part of default GokrazyPackages.#97
Merged
stapelberg merged 2 commits intogokrazy:mainfrom Jan 9, 2026
Merged
gok add: don't add packages that are already part of default GokrazyPackages.#97stapelberg merged 2 commits intogokrazy:mainfrom
stapelberg merged 2 commits intogokrazy:mainfrom
Conversation
…ackages. Adds an integration test for `gok add` since I couldn't find one. Fixes gokrazy/gokrazy#356.
Contributor
Author
|
@stapelberg please review and be warned this is my first foray into the gokrazy/tools repo :) |
stapelberg
requested changes
Jan 9, 2026
Contributor
stapelberg
left a comment
stapelberg
left a comment
There was a problem hiding this comment.
Looks good overall. At some point, I’ll refactor the tests to reduce duplication, but for now, this works.
stapelberg
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an integration test for
gok addsince I couldn't find one.Fixes gokrazy/gokrazy#356.