Merged
Conversation
pimousse1099
previously approved these changes
Sep 26, 2019
Member
pimousse1099
left a comment
pimousse1099
left a comment
There was a problem hiding this comment.
maybe add some check on the tests ?
Member
|
rebase needed |
pimousse1099
force-pushed
the
improve-request-id
branch
from
7a41ee8 to
8f3e596
Compare
Member
done |
instabledesign
commented
Sep 27, 2019
instabledesign
force-pushed
the
improve-request-id
branch
from
a949098 to
ec84367
Compare
pimousse1099
previously approved these changes
Sep 27, 2019
|
Code Climate has analyzed commit ea848d7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.1% (0.0% change). View more on Code Climate. |
qneyrat
previously approved these changes
Sep 27, 2019
pimousse1099
requested changes
Sep 27, 2019
tripperware/request_id_test.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/stretchr/testify/assert" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.