fix linkage issue in RH builds #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@derekparker thanks for all the help in root causing this. Merging this in would make things much easier since we can use the downstream RH as-is. |
derekparker
approved these changes
May 17, 2024
Contributor
derekparker
left a comment
derekparker
left a comment
There was a problem hiding this comment.
LGTM
I'm happy to merge this and then remove the downstream patch we carry.
Ping @dbenoit17 for a second +1 before merging.
sipasing
force-pushed
the
fix-linkage-issue
branch
from
c396c5d to
0cea428
Compare
derekparker
requested changes
May 17, 2024
sipasing
force-pushed
the
fix-linkage-issue
branch
from
0cea428 to
3180561
Compare
dbenoit17
requested changes
May 17, 2024
sipasing
force-pushed
the
fix-linkage-issue
branch
4 times, most recently
from
e3a9331 to
21e885e
Compare
sipasing
force-pushed
the
fix-linkage-issue
branch
from
21e885e to
3c3531f
Compare
Contributor
Author
|
@dbenoit17 @derekparker There seems to some sort of race condition in PR merges since we have two files with same names now in the main branch patches/015-fix-linkage.patch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go binary (tested with v1.21.7 on Oracle Linux) seems to be missing vendored openssl patches.
The above command returns nothing. Derek suggested that https://go-review.googlesource.com/c/go/+/454836 might be the reason for this.
I wanted to try a smaller change-set and so i think setting toolenv to empty string should work. I tried a make.bash and it worked and linkage is fine post that.
fixes #186
First time submitting a PR here, so please let me know if any changes are required.