Skip to content

Conversation

@sipasing
Copy link
Contributor

It seems between the time of filing PR #190 and the time of merging it, another patch file with same number (15) prefix was added to main branch.

patches/015-fix-linkage.patch
patches/015-add-hash-sign-verify.patch

Since the filenames are actually different, this shouldn't make any difference at runtime, but it would be good to renumber them for sanity.

@derekparker
Copy link
Contributor

Hey, I actually just merged another patch which takes 016 😅 can you update the patch file to 017?

@sipasing sipasing force-pushed the rename-patch-file branch from eca407d to e100e79 Compare May 21, 2024 19:10
@sipasing
Copy link
Contributor Author

hehe. Done.

Copy link
Contributor

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbenoit17 dbenoit17 merged commit 28c0d98 into golang-fips:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants