collapses arrays in the Gopkg.lock file

[JFixby]

There is this issue with dep collapsing package arrays.

Example:

before dep ensure

packages = [ 
    "agent", 
    "internal", 
    "signal" 
  ]

after dep ensure

packages = ["agent","internal","signal"]

What version of dep are you using (dep version)?

$git describe --tags
v0.4.1-171-g3e697f6a

Also this is Windows 8.1 machine.

What dep command did you run?

dep ensure

What did you expect to see?

Shouldn't collapse the arrays.

[sdboyer]

Hmm, i can't reproduce this, and we specifically turned on a while ago.

@pelletier any chance that go-toml doesn't produce windows newlines correctly? It seems unlikely, given that all of our output-checking tests pass on appveyor, but...

[pelletier]

I don't test go-toml on windows, so perhaps? go-toml only writes \n as a new line delimiter when writing out. Could you confirm the new lines are in fact not there at all (as opposed to whatever software is used that makes it look like they aren't)?

[JFixby]

I'll check it later.

[JFixby]

I'm sorry, I was wrong: the issue is actually with the Gopkg.lock file (not Gopkg.toml)

[sdboyer]

@JFixby yeah, i figured it was the lock. Still doesn't explain why it's happening, though 😢

Do you have access to Windows machines at other versions where you can check and see if the behavior exists? Do the arrays appear to be collapsed no matter what editor you're using to view Gopkg.lock?

[JFixby]

I have only one laptop with Windows 8.1.

I think editor doesn't matter. The issue really is that arrays in .lock file affect git diff, so I have to discard each hunk manually every time I'm trying to commit my code to a repo.

[JFixby]

Here is the an example diff:

[mmwtsn]

I am seeing this as well and it appears to be a Linux versus macOS issue:

$ dep version
dep:
 version     : v0.5.0
 build date  : 2018-07-26
 git hash    : 224a564
 go version  : go1.10.3
 go compiler : gc
 platform    : darwin/amd64
 features    : ImportDuringSolve=false

When I run dep ensure single-line arrays in my Gopkg.lock packages are expanded. A coworker of mine running the latest development release on Linux generates single-line arrays. IIRC we have been seeing a split between macOS and Linux behavior here for a few releases now. Maybe an OS issue?

[Clasyc]

Any news on this issue? Experiencing the same problem on ubuntu 18.04.

[pelletier]

@Clasyc can you paste dep version?

Also, I wonder if this could be an installation issue? Like having in the GOPATH an old version of go-toml pulled by some other project, and somehow that version gets used?

[Clasyc]

Sorry for the late response, but for no apparent reason, everything works as expected now. Can't reproduce problem again. Not sure what has changed during this time.

 version     : devel
 build date  : 
 git hash    : 
 go version  : go1.13.5
 go compiler : gc
 platform    : linux/amd64

[JFixby]

Solved by switching to GO111MODULE

[mvdan]

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!