Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Expand FAQ entry #1074

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Expand FAQ entry #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/FAQ.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,13 +296,13 @@ It's up to you:

**Pros**

- it's the only way to get truly reproducible builds, as it guards against upstream renames and deletes
- you don't need an extra `dep ensure` step (to fetch dependencies) on fresh clones to build your repo
- It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and commit history overwrites.
- You don't need an extra `dep ensure` step (to fetch dependencies) on fresh clones to build your repo: you can use `go get` as usual.

**Cons**

- your repo will be bigger, potentially a lot bigger
- PR diffs are more annoying
- Your repo will be bigger, potentially a lot bigger.
- PR diffs are more annoying (but files in `vendor/` are [hidden by default](https://github.com/github/linguist/blob/v5.2.0/lib/linguist/generated.rb#L328) on Github).
Copy link
Collaborator

@ibrasho ibrasho Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify that? [hidden by default in Github]

Copy link
Contributor Author

@AlekSi AlekSi Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example: https://github.com/percona/mysqld_exporter/pull/6/files Notice that vendor/github.com/percona/exporter_shared is hidden by default.


## How do I roll releases that `dep` will be able to use?

Expand Down