Removing "earth" overlap from S2 tests #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rsned This might be an acceptable solution for your previous comment, give me a shout and we can figure out what might be best. #239 (comment) |
jmr
reviewed
Dec 12, 2025
| func TestContainsPointQueryContainingShapes(t *testing.T) { | ||
| const numVerticesPerLoop = 10 | ||
| maxLoopRadius := kmToAngle(10) | ||
| maxLoopRadius := testRadiusMedium |
Collaborator
There was a problem hiding this comment.
This is not really helpful to me as a reader of the code. I know what 10 km on the Earth is. I need to go look to find out what testRadiusMedium is.
What is the problem you're trying to solve?
| numTargetEdges int | ||
| chooseTargetFromIndex bool | ||
| radiusKm s1.Angle | ||
| radius s1.Angle |
Collaborator
There was a problem hiding this comment.
This one looks reasonable to fix since km is not an angle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noting the "circular" implementation and import conflict in #239 … removing the "earth" subject matter (and their own tests like "TestKmToAngle") from the S2 tests to instead be about general spheres, citing Earth as a planet in some cases but not using hard-coded values.