Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/gopherbot: -2 any CLs with large binary blobs unless declared in commit message #10658
Slightly off-topic, but why not, @mwhudson? What do you do instead?
If this were added, it would be a pre-commit hook, so if you use the hooks, it'd be picked up.
I agree that we should enforce some simple size rules on the gerrit side, but doing it here too lets us put in more subtle and more restrictive detection logic, which the user can intentionally overrule. I like @nightlyone's suggestion for that. Overruling a gerrit check is way beyond a reviewer sanity-check.
On 4 May 2015 at 05:26, Josh Bleecher Snyder email@example.com
changed the title
x/review/git-codereview: don't allow binary files to be added
Feb 21, 2018
I've retitled this to reflect my new short-term implementation plan in light of all the recent accidents.
We can do this pretty easily and quickly in gopherbot by making it vote -2 on any Gerrit CL it seems with large files if they're not declared in the commit message.
Looking at the data in maintner for https://go-review.googlesource.com/c/go/+/151318 I see the diff summary:
Note that for issue2331.dir we just see:
No number for the size of the blob. We need to add that to maintner first. Or have gopherbot just git fetch the thing and run a local