Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/vet: should check for missing call to "Err() error" methods #17747
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
There are legitimate cases in which you might elide the s.Err check, such as when reading lines from a
How frequently is frequently? How bad are the resulting bugs?
It probably comes up in code review at least once or twice per week. Typically when interacting with a database.
As far as the severity of the resulting bugs, I am not sure. I'm on a different team and often just get asked to do code review sporadically, even though I typically don't maintain the projects where these problems occur.