x/build: we should run at least one windows builder as Administrator #23294
Comments
Do the linux tests run as root? Perhaps this is done on purpose to avoid breaking the machines. Is there a way to grant privileges to create symlinks, but no more? |
Naah, we create new ephemeral VMs or containers per build for almost all the builders. I don't know why Windows runs as a normal user. @johnsonj, you remember? The Linux builders mostly run as kinda-root: the root that you have in a Kubernetes container, which can do most things, but not all. We used to run a VM-based Linux builder too so we could have real root, but that's been disabled for some time now. |
The only special user thing I remember is we needed to run as a real logged in session and not as SYSTEM. I don't think there is a reason why they can't run as an elevated user. Does it need to be the actual 'Administrator' user or just a user in the group? |
I think it needs to be the 'Administrator'. See my original output was produced by the user who is in local 'Administrator' group. And the second output was produced when I started cmd.exe via "Run as Administrator". Just jump on the builder and run some tests that were skipped above and see what you get. Thank you Alex |
This bug might be about the opposite now, if I understand #24855 correctly. This bug should be more generally about making sure we test as both admin & non-admin. |
Yes. We do not actually know if builders run as admin or non-admin. So we need to run both kind of builders. It is fine for this bug to be about that. Alex |
Some tests do not run unless they are run by Administrator.
Compare normal user runs:
to Administrator runs:
We have 5 windows builders at this moment. Perhaps we could make some run as Administrator to cover more tests.
Thank you.
Alex
The text was updated successfully, but these errors were encountered: