New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run ssacheck mode for all architectures, not just amd64 #24016

Open
josharian opened this Issue Feb 21, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@josharian
Contributor

josharian commented Feb 21, 2018

We have an amd64 ssacheck builder. That builder should compile std+cmd for all architectures, not just native. That would have prevented or at least caught #24014.

@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2018

@gopherbot gopherbot added the Builders label Feb 21, 2018

@bradfitz

This comment has been minimized.

Member

bradfitz commented Feb 21, 2018

We already have a bunch of misc-compile builders. Can we just make them ssacheck too?

@josharian

This comment has been minimized.

Contributor

josharian commented Feb 21, 2018

SGTM. It’ll make them a bit slower, but that seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment