os: TestDevNullFile is broken on Solaris

[alexbrainman]

I just submitted CL 102457 that added more checks to TestDevNullFile and new test fails on Solaris.

https://build.golang.org/log/924e0064b500c0b807dcadcf4e7acc2f94e232ec

--- FAIL: TestDevNullFile (0.00s)
	os_test.go:1807: Lstat("/dev/null"): wrong file size have 27 want 0
	os_test.go:1810: Lstat("/dev/null"): wrong file mode "Lrwxrwxrwx": ModeDevice is not set
	os_test.go:1813: Lstat("/dev/null"): wrong file mode "Lrwxrwxrwx": ModeCharDevice is not set
FAIL
FAIL	os	0.852s

I do not know enough about Solaris to decide if that is wrong test or broken Lstat implementation.

If anyone knows which, please, let me know, and I will skip Lstat part of the test on Solaris, or remove Lstat part altogether.

Thank you.

Alex

[alexbrainman]

Just to make it more interesting - there are 2 Solaris builders: solaris-amd64-oraclerel (TestDevNullFile failed there) and solaris-amd64-smartosbuildlet (TestDevNullFile succeeded).

Alex

[tklauser]

It seems /dev/null is a symlink on solaris-amd64-oraclerel.

[alexbrainman]

It seems /dev/null is a symlink on solaris-amd64-oraclerel.

I realised that now. Sending a CL.

Alex

[gopherbot]

Change https://golang.org/cl/102461 mentions this issue: os: do not test Lstat in TestDevNullFile