Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestDevNullFile is broken on Solaris #24521

Closed
alexbrainman opened this issue Mar 25, 2018 · 4 comments
Closed

os: TestDevNullFile is broken on Solaris #24521

alexbrainman opened this issue Mar 25, 2018 · 4 comments

Comments

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Mar 25, 2018

I just submitted CL 102457 that added more checks to TestDevNullFile and new test fails on Solaris.

https://build.golang.org/log/924e0064b500c0b807dcadcf4e7acc2f94e232ec

--- FAIL: TestDevNullFile (0.00s)
	os_test.go:1807: Lstat("/dev/null"): wrong file size have 27 want 0
	os_test.go:1810: Lstat("/dev/null"): wrong file mode "Lrwxrwxrwx": ModeDevice is not set
	os_test.go:1813: Lstat("/dev/null"): wrong file mode "Lrwxrwxrwx": ModeCharDevice is not set
FAIL
FAIL	os	0.852s

I do not know enough about Solaris to decide if that is wrong test or broken Lstat implementation.

If anyone knows which, please, let me know, and I will skip Lstat part of the test on Solaris, or remove Lstat part altogether.

Thank you.

Alex

@alexbrainman

This comment has been minimized.

Copy link
Member Author

@alexbrainman alexbrainman commented Mar 25, 2018

Just to make it more interesting - there are 2 Solaris builders: solaris-amd64-oraclerel (TestDevNullFile failed there) and solaris-amd64-smartosbuildlet (TestDevNullFile succeeded).

Alex

@tklauser

This comment has been minimized.

Copy link
Member

@tklauser tklauser commented Mar 26, 2018

It seems /dev/null is a symlink on solaris-amd64-oraclerel.

@alexbrainman

This comment has been minimized.

Copy link
Member Author

@alexbrainman alexbrainman commented Mar 26, 2018

It seems /dev/null is a symlink on solaris-amd64-oraclerel.

I realised that now. Sending a CL.

Alex

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 26, 2018

Change https://golang.org/cl/102461 mentions this issue: os: do not test Lstat in TestDevNullFile

@gopherbot gopherbot closed this in d2dd2e1 Mar 26, 2018
@golang golang locked and limited conversation to collaborators Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.