Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/ssa: a wrong arm64 rule #24907

Closed
benshi001 opened this issue Apr 18, 2018 · 1 comment

Comments

@benshi001
Copy link
Member

commented Apr 18, 2018

In the file cmd/compile/internal/ssa/gen/ARM64.rules, line 1468 - 1498.

The rule seems to combine 8 load-byte to a single LE load dword. However the final REV is wrong, since it is a LE load.

I will correct it along with my CL touching that part.

@ALTree ALTree added the NeedsFix label Apr 18, 2018
@ALTree ALTree added this to the Go1.11 milestone Apr 18, 2018
@gopherbot

This comment has been minimized.

Copy link

commented Apr 19, 2018

Change https://golang.org/cl/107376 mentions this issue: cmd/compile: optimize ARM64 with register indexed load/store

@gopherbot gopherbot closed this in 34f5f8a Apr 19, 2018
@golang golang locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.