New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add Fedora builder #26796

Open
bradfitz opened this Issue Aug 3, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@bradfitz
Member

bradfitz commented Aug 3, 2018

We have a Debian-sid builder. Also add Fedora?

Would've helped with https://go-review.googlesource.com/c/go/+/127895 (for #26369)

@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2018

@gopherbot gopherbot added the Builders label Aug 3, 2018

@jcajka

This comment has been minimized.

Contributor

jcajka commented Aug 10, 2018

For the record it would also helped with catching earlier https://go-review.googlesource.com/c/go/+/86541 for #23373
It will help with GC to test integration with latets binutils, glibc, kernel,... (latest versions generally pop sooner in Fedora than in Debian)
I would be happy (as Fedora's GC maintainer) to help with maintaining it and investigating and fixing the build failures.
Can you advise what can I do to help make it happen?

@bradfitz

This comment has been minimized.

Member

bradfitz commented Aug 10, 2018

Well, adding a Fedora container is trivial & easy for us. But the downside is we'd be using the Linux kernel of https://cloud.google.com/container-optimized-os/ . That's a pretty recent kernel always, but might be configured differently than Fedora.

We could add a full Fedora VM image (as we do for a dozen other non-Linux operating systems/versions), but it's more work. (We need to prepare a script which when run on Linux produces a bootable GCE VM image. See the Plan 9 and BSDs in https://github.com/golang/build/tree/master/env)

@jcajka

This comment has been minimized.

Contributor

jcajka commented Aug 28, 2018

Sorry for longer reply time.

I think that both could be beneficial. For containers I think that fedora:rawhide and fedora:latest should be used to test both against the unstable rawhide and latest stable release. Rawhide more like non-blocking smoke test(it could be broken/stale from time to time).

After taking quick peak at the GCE and the scripts. It doesn't support the regular AWS or openstack image formats, right?(Fedora Cloud images are produced for those.) Is there some summary of what needs GCE and Go CI to run(it would be much easier than revers engineering the scripts)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment