New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: Transport is leaking streams on broken Body [1.11 backport] #28673

Closed
gopherbot opened this Issue Nov 8, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@gopherbot

gopherbot commented Nov 8, 2018

@bradfitz requested issue #27208 to be considered for backport to the next 1.11 minor release.

@gopherbot, please backport to Go 1.11.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 8, 2018

Note that this is a tricky one: it requires an x/net cherry-pick followed by a manual bundle into std's net/http h2_bundle.go file.

/cc @dmitshur

@gopherbot

This comment has been minimized.

gopherbot commented Dec 14, 2018

Change https://golang.org/cl/154237 mentions this issue: [release-branch.go1.11] http2: don't leak streams on broken body

@gopherbot

This comment has been minimized.

gopherbot commented Dec 14, 2018

Closed by merging a4630153038d3cb8c57f83d95200aea356145cf5 to release-branch.go1.11.

@gopherbot gopherbot closed this Dec 14, 2018

gopherbot pushed a commit to golang/net that referenced this issue Dec 14, 2018

[release-branch.go1.11] http2: don't leak streams on broken body
Updates golang/go#28673

Change-Id: I5d9a643f33d27d33b24f670c98f5a51aa6000967
GitHub-Last-Rev: 3ac4a57
GitHub-Pull-Request: #18
Reviewed-on: https://go-review.googlesource.com/c/132715
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1c5f79c)
Reviewed-on: https://go-review.googlesource.com/c/154237
@dmitshur

This comment has been minimized.

Member

dmitshur commented Dec 14, 2018

Re-opening for bundling into standard library's net/http h2_bundle.go file.

@dmitshur dmitshur reopened this Dec 14, 2018

@gopherbot gopherbot closed this Dec 14, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Dec 14, 2018

Change https://golang.org/cl/154298 mentions this issue: [release-branch.go1.11] net/http: update bundled x/net/http2

@bradfitz

This comment has been minimized.

Member

bradfitz commented Dec 14, 2018

Why is gopherbot closing this?

@bradfitz bradfitz reopened this Dec 14, 2018

@gopherbot gopherbot closed this Dec 14, 2018

@bradfitz bradfitz reopened this Dec 14, 2018

@gopherbot gopherbot closed this Dec 14, 2018

gopherbot pushed a commit that referenced this issue Dec 14, 2018

[release-branch.go1.11] net/http: update bundled x/net/http2
This updates x/net/http2 to x/net on the latest commit of x/net on
release-branch.go1.11 branch, golang/net@a463015, for:

	[release-branch.go1.11] http2: don't leak streams on broken body
	https://golang.org/cl/154237

Fixes #28673

Change-Id: I8f40c69502fa95d1d9dff1ab68444640444442aa
Reviewed-on: https://go-review.googlesource.com/c/154298
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment