Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: missing SETTINGS_HEADER_TABLE_SIZE support #29356

Open
rs opened this issue Dec 20, 2018 · 3 comments
Open

x/net/http2: missing SETTINGS_HEADER_TABLE_SIZE support #29356

rs opened this issue Dec 20, 2018 · 3 comments
Labels
NeedsDecision
Milestone
Backlog

Comments

@rs
Copy link
Contributor

@rs rs commented Dec 20, 2018 •
edited

There are TODO comments in the code about SETTINGS_HEADER_TABLE_SIZE support. Proper would:

  • Give the ability to setup a max table size at http2.Transport and http2.Server
  • Send the max table size in the settings frame
  • Apply received SETTINGS_HEADER_TABLE_SIZE capped by the max table size defined

I have a working implementation. I need to write tests and I will submit it.

Cc @bradfitz
@rs rs changed the title x x/net/http2: missing SETTINGS_HEADER_TABLE_SIZE support Dec 20, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 27, 2018

Change https://golang.org/cl/155877 mentions this issue: http2: add SETTINGS_HEADER_TABLE_SIZE support
@katiehockman katiehockman changed the title x/net/http2: missing SETTINGS_HEADER_TABLE_SIZE support net/http2: missing SETTINGS_HEADER_TABLE_SIZE support Jan 2, 2019
@katiehockman katiehockman added this to the Go1.13 milestone Jan 2, 2019
@rs
Copy link
Contributor Author

@rs rs commented Jan 2, 2019

@katiehockman: all other issues related to x/net/http2 are prefixed with x/. What drove your decision to remove x/ here?
@katiehockman katiehockman changed the title net/http2: missing SETTINGS_HEADER_TABLE_SIZE support x/net/http2: missing SETTINGS_HEADER_TABLE_SIZE support Jan 2, 2019
@katiehockman
Copy link
Member

@katiehockman katiehockman commented Jan 2, 2019

Just a mistake. Thanks for letting me know. Updated it.
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision
Projects
None yet
Milestone
  Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@rs @rsc @andybons @gopherbot @katiehockman
You can’t perform that action at this time.