net/http: new TestDontCacheBrokenHTTP2Conn fails #35113
Comments
This happens when I test https://go-review.googlesource.com/c/go/+/202797. |
Sigh |
This was just introduced in https://go-review.googlesource.com/c/go/+/202078 for #34978 (and backported to Go 1.13, sadly too early apparently). Looking. |
I can repro:
|
Note that #35087 never actually got the |
Soaking before cherry-picking is new to me. That's a thing we do now? I mean, not a terrible idea, but first I'd heard. |
It's a thing I've been doing informally, at least. (#31887) Not a formal policy, as far as I'm aware. |
At any rate: for the race condition! Would it make sense to add synchronization between the |
@bradfitz not sure it's related, but if I apply this patch, the test won't fail even with
|
The test still fails at |
|
Change https://golang.org/cl/206819 mentions this issue: |
Not a fix, but will give us more info when it flakes again. Updates #35113 Change-Id: I2f90c24530c1bea81dd9d8c7a59f4b0640dfa4c2 Reviewed-on: https://go-review.googlesource.com/c/go/+/206819 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
@bradfitz, any thoughts on how we should address this? |
No immediate thoughts. I need to get it all in my head again and debug but I've been busy with other stuff. I'll try work on it this week. |
Change https://golang.org/cl/218097 mentions this issue: |
I'm looking for another reviewer. If I can't find one I'll dig into the code a bit more and see if I can get comfortable enough to +2 it myself. |
I'm looking at this and the earlier CL. |
Change https://golang.org/cl/220905 mentions this issue: |
FWIW, I see the same test failing on Mojave (as part of running all.bash on 1.4).
|
Build log: https://storage.googleapis.com/go-build-log/76c387a0/linux-amd64-race_356de3ff.log
The text was updated successfully, but these errors were encountered: