Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: better docs for PreferGo in Resolver #35561

Open
renanbastos93 opened this issue Nov 13, 2019 · 6 comments

Comments

@renanbastos93
Copy link

@renanbastos93 renanbastos93 commented Nov 13, 2019

Guys, how are you?

I have a suggestion to improve doc about parameter PreferGo on struct Resolver based on a comment in another issue. #19268 (comment)

Suggestion adds more a small text:

When you use the variable PreferGo set to true you will be 
able to use your dial, If you use PreferGo set to false it will ignore 
your dial and use directly "/etc/resolv.conf "

Reference Doc:

// PreferGo controls whether Go's built-in DNS resolver is preferred

@ianlancetaylor ianlancetaylor changed the title Improve doc about struct Resolver in var PreferGo net: better docs for PreferGo in Resolver Nov 13, 2019
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Nov 13, 2019
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 13, 2019

If I understand you correctly, you are suggesting that we clearly document that if PreferGo is set to false, then the Dial method in the Resolver will not be used. Is that correct?

@renanbastos93

This comment has been minimized.

Copy link
Author

@renanbastos93 renanbastos93 commented Nov 13, 2019

If I understand you correctly, you are suggesting that we clearly document that if PreferGo is set to false, then the Dial method in the Resolver will not be used. Is that correct?

Hello, @ianlancetaylor

I am so sorry for my English. I'm in a constant improvement in English skills.
Well, yes correctly. When set false in PreferGo it will ignore your Dial and will be using a default.

@renanbastos93

This comment has been minimized.

Copy link
Author

@renanbastos93 renanbastos93 commented Nov 14, 2019

I was thinking if you agreed to this improvement, I can open a pull request.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 15, 2019

I agree with the improvement in general, but I don't agree with the text proposed in the original message.

@renanbastos93

This comment has been minimized.

Copy link
Author

@renanbastos93 renanbastos93 commented Nov 15, 2019

I agree with the improvement in general, but I don't agree with the text proposed in the original message.

Ok, no problem.
What's your suggestion?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 15, 2019

I'm sorry, I don't have one right now. It will take some thought and this doesn't seem urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.