-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: better docs for PreferGo in Resolver #35561
Comments
If I understand you correctly, you are suggesting that we clearly document that if |
Hello, @ianlancetaylor I am so sorry for my English. I'm in a constant improvement in English skills. |
I was thinking if you agreed to this improvement, I can open a pull request. |
I agree with the improvement in general, but I don't agree with the text proposed in the original message. |
Ok, no problem. |
I'm sorry, I don't have one right now. It will take some thought and this doesn't seem urgent. |
@ianlancetaylor , I see the documentation is updated (at https://golang.org/pkg/net/#Resolver) indicting that "PreferGo" is a switch between Go's built-in DNS resolver or CGO resolver (which uses "getaddrinfo" or "getnameinfo"). Does using CGO resolver disable us using DNS dialer? Suppose I want to use CGO resolver with custom DNS server. |
@ozn0417 Yes, using the cgo resolver means that it will use the DNS servers listed in |
Guys, how are you?
I have a suggestion to improve doc about parameter
PreferGo
on struct Resolver based on a comment in another issue. #19268 (comment)Suggestion adds more a small text:
Reference Doc:
go/src/net/lookup.go
Line 120 in a38a917
The text was updated successfully, but these errors were encountered: