Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: README relative image links are broken #37194

Closed
kindermoumoute opened this issue Feb 12, 2020 · 3 comments
Closed

x/pkgsite: README relative image links are broken #37194

kindermoumoute opened this issue Feb 12, 2020 · 3 comments
Assignees
@jamalc
Labels
NeedsFix pkgsite
Milestone
pkgsite/frontend

Comments

@kindermoumoute
Copy link

@kindermoumoute kindermoumoute commented Feb 12, 2020

In tab overview all relative urls from the README.md are correctly replaced to absolute urls using GitHub's base url. This should be done as well for relative image path.

What did you do?

Go to https://pkg.go.dev/github.com/scaleway/scaleway-sdk-go?tab=overview

What did you expect to see?

Image rendering correctly

What did you see instead?

Broken image link
@gopherbot gopherbot added this to the Unreleased milestone Feb 12, 2020
@gopherbot gopherbot added the pkgsite label Feb 12, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 12, 2020

/cc @jba
@julieqiu julieqiu added the NeedsFix label Feb 12, 2020
@julieqiu julieqiu changed the title go.dev: relative image link is broken go.dev: README relative image links are broken Feb 19, 2020
@julieqiu julieqiu mentioned this issue May 28, 2020
Closed
@jba
Copy link
Contributor

@jba jba commented May 29, 2020

The problem here is that the img link is in HTML, not Markdown. We currently traverse the markdown, but not the HTML embedded within it.
@julieqiu julieqiu changed the title go.dev: README relative image links are broken x/pkgsite: README relative image links are broken Jun 15, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 27, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 22, 2020
@gopherbot gopherbot added the go.dev label Sep 22, 2020
@julieqiu julieqiu removed the go.dev label Sep 22, 2020
@jamalc jamalc self-assigned this Nov 18, 2020
@jamalc
Copy link
Member

@jamalc jamalc commented Nov 18, 2020

@kindermoumoute - this should now be fixed.
@jamalc jamalc closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamalc jamalc

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@julieqiu @gopherbot @kindermoumoute @jamalc @jba