Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add support for syntax highlighting of code blocks #40952

Open
codyoss opened this issue Aug 21, 2020 · 3 comments
Open

x/pkgsite: add support for syntax highlighting of code blocks #40952

codyoss opened this issue Aug 21, 2020 · 3 comments

Comments

@codyoss
Copy link
Member

@codyoss codyoss commented Aug 21, 2020

What is the URL of the page with the issue?

Any containing code blocks. Example: https://pkg.go.dev/cloud.google.com/go/storage?tab=doc#hdr-Objects

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Screenshot

Screen Shot 2020-08-21 at 9 42 20 AM

What did you do?

Navigate to the page.

What did you expect to see?

Code blocks with syntax highlighting.

What did you see instead?

Code blocks as plain text.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 21, 2020

Thanks for the suggestion, @codyoss!

/cc @spf13 @Joanne881107 @fflewddur for product / UX input

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 21, 2020

Note that there also exist some preformated text blocks that don't contain Go code. For example:

image

(Source: https://pkg.go.dev/cmd/asm#hdr-Command_Line)

@codyoss
Copy link
Member Author

@codyoss codyoss commented Aug 21, 2020

Note that there also exist some preformated text blocks that don't contain Go code

That is a very good point I had not thought of... Might make this quite tricky(infeasible?) as there is no way today to call out what is contained in the block.(i.e. the way markdown supports "```go")

@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.