Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: experimentalDiagnosticsDelay causes diagnostics to flash #42363

Closed
stamblerre opened this issue Nov 3, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 3, 2020

When a package has only analysis diagnostics and experimentalDiagnosticsDelay is set, the diagnostic cache does not work correctly and diagnostics flash between empty and the results with analysis.

/cc @findleyr

@stamblerre stamblerre added this to the gopls/vscode-go milestone Nov 3, 2020
@findleyr findleyr self-assigned this Nov 3, 2020
@findleyr findleyr assigned stamblerre and unassigned findleyr Nov 4, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2020

Change https://golang.org/cl/267817 mentions this issue: internal/lsp: fix flickering analysis diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.