Skip to content

x/website: hamburger menu doesn't work on mobile #47862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Waqas-Shah-42 opened this issue Aug 21, 2021 · 3 comments
Closed

x/website: hamburger menu doesn't work on mobile #47862

Waqas-Shah-42 opened this issue Aug 21, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@Waqas-Shah-42
Copy link

The index button ( the 3 lines button) does not work on safari iOS
@seankhliao seankhliao changed the title A button not clicking x/website: hamburger menu doesn't work on iOS Aug 21, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2021
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 21, 2021
@seankhliao
Copy link
Member

I assume this is golang.org where it also doesn't do anything on my iphone

cc @dmitshur

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/344309 mentions this issue: golang.org: fix hamburger menu

@seankhliao seankhliao mentioned this issue Aug 27, 2021
Closed
@fzipp fzipp mentioned this issue Aug 28, 2021
Closed
@seankhliao seankhliao changed the title x/website: hamburger menu doesn't work on iOS x/website: hamburger menu doesn't work on mobile Aug 28, 2021
@seankhliao seankhliao mentioned this issue Sep 5, 2021
Closed
This was referenced Sep 12, 2021
Closed
Closed
@alex-mous
Copy link

alex-mous commented Sep 18, 2021 •
edited
Loading

This bug also occurs on Chrome on iPhone iOS (ver. 93.0.4577.39).

@golang golang locked and limited conversation to collaborators Sep 20, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
_content, go.dev: fix hamburger menu
4e6da7e 
Follow up on https://golang.org/cl/343469.

Use different classes for the hamburger menu to set
event listeners on golang.org & go.dev to avoid
(mis-)listing the paths.

Fixes golang/go#47862.

Change-Id: I4bbf856cd86583bea402b1869583e90799a7d1f9
Reviewed-on: https://go-review.googlesource.com/c/website/+/344309
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@gopherbot @seankhliao @Waqas-Shah-42 @alex-mous