Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: if (*ClientConn).encodeHeaders returns an error, roundTrip doesn't clean up streams map, etc #48652

Open
bradfitz opened this issue Sep 27, 2021 · 1 comment
Labels
NeedsInvestigation
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Sep 27, 2021

If you send try to RoundTrip a bogus request that trips up (*ClientConn).encodeHeaders, the (*ClientConn).roundTrip function returns without cleaning up the cc.streams map, etc.

/cc @neild

@mknyszek mknyszek added the NeedsInvestigation label Oct 4, 2021
@mknyszek mknyszek added this to the Backlog milestone Oct 4, 2021
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Oct 4, 2021

CC @neild

@mknyszek mknyszek removed this from the Backlog milestone Oct 4, 2021
@mknyszek mknyszek added this to the Unreleased milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

2 participants