-
Notifications
You must be signed in to change notification settings - Fork 19k
x/pkgsite: No skip to content button on search page #52248
Copy link
Copy link
Open
Labels
FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.Feedback is required from experts, contributors, and/or the community before a change can be made.pkgsitepkgsite/searchIssues related to pkg.go.dev search functionalityIssues related to pkg.go.dev search functionality
Milestone
Description
Metadata
Metadata
Assignees
Labels
FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.Feedback is required from experts, contributors, and/or the community before a change can be made.pkgsitepkgsite/searchIssues related to pkg.go.dev search functionalityIssues related to pkg.go.dev search functionality
Type
Fields
Give feedbackNo fields configured for issues without a type.
What is the URL of the page with the issue?
https://pkg.go.dev/search?q={searchTerm}
What is your user agent?
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.79 Safari/537.36
Screenshot
Adding GIF to show problem
What did you do?
Tried navigating the page using Tab
What did you expect to see?
A skip to content button at first that skips the navigation/header and probably also the search bar
What did you see instead?
I had to tab through the navigation and the search bar
Solution
Adding a skip to content button that is highest up in the document tree (that is, will be the first element to come into focus when tab navigating). It should also normally be hidden and only show up when has focus. Clicking (or basically pressing enter on the keyboard when it has focus) should skip the navigation (and probably the search bar as well) so as to when one presses tab after that, the focus is on the packages.
Example: Google search does this - https://www.google.com/search?q=go (open the URL and try to navigate with tab)