Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: No skip to content button on search page #52248

Open
AnishDe12020 opened this issue Apr 9, 2022 · 0 comments
Open

x/pkgsite: No skip to content button on search page #52248

AnishDe12020 opened this issue Apr 9, 2022 · 0 comments
Labels
FeatureRequest pkgsite/search pkgsite

Comments

@AnishDe12020
Copy link

@AnishDe12020 AnishDe12020 commented Apr 9, 2022

What is the URL of the page with the issue?

https://pkg.go.dev/search?q={searchTerm}

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.79 Safari/537.36

Screenshot

Adding GIF to show problem

Peek 2022-04-09 12-08

What did you do?

Tried navigating the page using Tab

What did you expect to see?

A skip to content button at first that skips the navigation/header and probably also the search bar

What did you see instead?

I had to tab through the navigation and the search bar

Solution

Adding a skip to content button that is highest up in the document tree (that is, will be the first element to come into focus when tab navigating). It should also normally be hidden and only show up when has focus. Clicking (or basically pressing enter on the keyboard when it has focus) should skip the navigation (and probably the search bar as well) so as to when one presses tab after that, the focus is on the packages.

Example: Google search does this - https://www.google.com/search?q=go (open the URL and try to navigate with tab)

@gopherbot gopherbot added this to the pkgsite/search milestone Apr 9, 2022
@hyangah hyangah added the pkgsite/search label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest pkgsite/search pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants