x/tools/gopls: inconsistent semantic token types for type parameters

[rink-grey]

As example, the function has a generic typeParameter "T" and a parameter "target" .

Inside function, it check "target" as typeParameter that is error. Obviously "target" is a parameter.


And in the generic list, it check "T" as parameter, but in the parameter list, it check "T" as typeParameter. That is confusion

And my setting of gopls.ui.semanticTokens is turning on.

[findleyr]

CC @pjweinb

I think it should be the other way around: target is a parameter, and T is a typeParameter (both in the type parameter list and parameter list).

[rink-grey]

@findleyr
yes, and inside the function body, "target" should be a parameter, not a typeParameter.
A parameter means a variable, and a typeParameter means a type.

CC @pjweinb

I think it should be the other way around: target is a parameter, and T is a typeParameter (both in the type parameter list and parameter list).

[gopherbot]

Change https://go.dev/cl/448375 mentions this issue: gopls/semantic: semantic tokens for type parameters