-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: TestUsingVDSO failures #63734
Comments
Found new dashboard test flakes for:
2023-10-14 22:30 linux-386-clang go@bc9dc8d4 runtime.TestUsingVDSO (log)
|
Found new dashboard test flakes for:
2024-01-12 00:55 linux-386-buster go@eb30ac34 runtime.TestUsingVDSO (log)
|
That's two on @golang/runtime: given the above, should this be a release-blocker (to either fix or add a skip for the test)? |
This smells like an strace bug. If the subprocess itself were SIGSEGV'ing, I would expect strace to report that signal. If so, then this a test-only failure, and I'd be fine with doing a SkipFlaky if strace exits with a SIGSEGV, or perhaps just retrying the test so we catch persistent failures. |
For example, if the test binary itself were failing, I would expect output like this before strace exited with SIGSEGV:
The "killed by SIGSEGV" would only appear if we fail before installing signal handlers, but then I would expect other tests to be failing in the same way. If we're failing after installing signal handlers, we'd still see the first line, and then the process would exit with status 2, not SIGSEGV. So, it's definitely strace itself that's crashing. |
Change https://go.dev/cl/556357 mentions this issue: |
Very occasionally, at least on linux/386, strace itself will crash in TestUsingVDSO. Detect these crashes and just skip the test. Fixes golang#63734. Change-Id: I050494459d47dd96c0b8dc0b16353cb532fba93e Reviewed-on: https://go-review.googlesource.com/c/go/+/556357 Auto-Submit: Austin Clements <austin@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: