Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add LUCI linux-ppc64-power10 builder. #64588

Open
pmur opened this issue Dec 6, 2023 · 9 comments
Open

x/build: add LUCI linux-ppc64-power10 builder. #64588

pmur opened this issue Dec 6, 2023 · 9 comments
Assignees
Labels
arch-ppc64x Builders x/build issues (builders, bots, dashboards) new-builder OS-Linux
Milestone

Comments

@pmur
Copy link
Contributor

pmur commented Dec 6, 2023

This will be the LUCI GOPPC64=power10 GOARCH=ppc64 GOOS=linux builder replacement for host-linux-ppc64-sid-power10.

It will share the same VM resources as host-linux-ppc64-sid-power10. The hostname should be linux-ppc64-power10.

Certificate attached: linux-ppc64-power10.csr.txt

@pmur pmur self-assigned this Dec 6, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 6, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Dec 7, 2023

Thanks. This is similar to #61274, except it's GOARCH=ppc64 and GOPPC64=power10.

CC @golang/release.

@gopherbot
Copy link

Change https://go.dev/cl/548217 mentions this issue: main.star: add linux-ppc64 builders

gopherbot pushed a commit to golang/build that referenced this issue Dec 8, 2023
For golang/go#64588

Change-Id: I59ce0dec9caa4d2080d27d4649f1a6b01de7afab
Reviewed-on: https://go-review.googlesource.com/c/build/+/548217
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis
Copy link
Contributor

Here's the resulting certificate: linux-ppc64-power10-1702068073.cert.txt.

The builder definitions have been added in CL 548217 so your bot should be able to connect once you follow the rest of the steps on your end.

@pmur
Copy link
Contributor Author

pmur commented Dec 8, 2023

Thanks! I have one instance started and running.

@dmitshur
Copy link
Contributor

dmitshur commented Dec 8, 2023

That was fast, and we now have its first green build!

https://ci.chromium.org/b/8762240340084651697

Thanks very much. Would you like to keep this issue open a bit longer (e.g., while you're adding more instances), or okay to close now?

@pmur
Copy link
Contributor Author

pmur commented Dec 8, 2023

Is the GOPPC64=power10 envvar configured for this builder? I didn't see it listed when I clicked through the log above. Should I be configuring that on the builder itself, or is the luci coordinator responsible for setting that?

@dmitshur
Copy link
Contributor

dmitshur commented Dec 8, 2023

Good point, it ended up as its default value of power8.

The optimal place to set it might be in our builder configuration (edit: sent CL 547982 for this), though it's also okay for you to do it in the builder's environment if that doesn't get in the way of something else.

Update: It's using GOPPC64=power10 now: https://ci.chromium.org/b/8762229504785642993.

@gopherbot
Copy link

Change https://go.dev/cl/547982 mentions this issue: main.star: set GOPPC64=power10 in linux-ppc64 builder environment

gopherbot pushed a commit to golang/build that referenced this issue Dec 9, 2023
This builder is intended to test the linux/ppc64 port with GOPPC64
set to power10, up from its default value of power8. Use a run mod
to achieve this.

For golang/go#64588.

Change-Id: I535e42d1e8e41b54e00b08474ff7d4f6b2712c52
Reviewed-on: https://go-review.googlesource.com/c/build/+/547982
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Jan 8, 2024

Checking in on the status of this in progress new-builder issue. Is there more to do here before closing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-ppc64x Builders x/build issues (builders, bots, dashboards) new-builder OS-Linux
Projects
Status: In Progress
Development

No branches or pull requests

4 participants