-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: integer divide by zero in predictN #70709
Comments
|
On linux/amd64 I can't reproduce by default.
Manually switching the clocksource to the less accurate Looking through the code some codepaths sanitize the nanoseconds before calling |
Also reproduces on an M1 Pro machine.
I did that locally (in B.stopOrScaleBLoop) and can confirm it stops it from reproducing. Thanks. |
Change https://go.dev/cl/633419 mentions this issue: |
Go version
go version devel go1.24-3ae00f5d29 Fri Dec 6 02:16:12 2024 +0000 darwin/arm64
Output of
go env
in your module/workspace:What did you do?
Ran all.bash at Go tip (commit 3ae00f5).
What did you see happen?
benchmark.go:283 is https://cs.opensource.google/go/go/+/master:src/testing/benchmark.go;l=283;drc=5213e1e56c17bde612398dac8a2996bf020fe542.
So far it only happened the one time, and doesn't trivially reproduce when running testing package tests on its own:
What did you expect to see?
All tests passing.
CC @JunyangShao, @prattmic.
The text was updated successfully, but these errors were encountered: