crypto/internal/fips140/aes: amd64 generator of CTR assembly is broken in Go 1.25

[starius]

Go version

go version go1.25.1 linux/amd64

Output of go env in your module/workspace:

AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/home/user/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/home/user/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3982408260=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/dev/null'
GOMODCACHE='/home/user/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/user'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/nix/store/f01qkydd3c2jqwi4w6hkddkf3blp16kw-go-1.25.1/share/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/user/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/nix/store/f01qkydd3c2jqwi4w6hkddkf3blp16kw-go-1.25.1/share/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.25.1'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

I got the most recent Go from Github (commit a5f55a4) and tried to re-generate Go's AES CTR assembly code:

$ cd go/src/crypto/internal/fips140/aes/_asm/ctr/
$ go generate

What did you see happen?

$ cd go/src/crypto/internal/fips140/aes/_asm/ctr/
$ go generate
# golang.org/x/tools/internal/tokeninternal
/home/user/pkg/mod/golang.org/x/tools@v0.24.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
ctr_amd64_asm.go:16: running "go": exit status 1

What did you expect to see?

I expected it to re-generate file "src/crypto/internal/fips140/aes/ctr_amd64.s" successfully.

[gabyhelp]

Related Issues

• x/tools: v0.8.0 through v0.25.0 (Oct 2024) contain public packages that fail to build with Go 1.25.0 #74462
• x/crypto/curve25519/internal/field/_asm: running `go generate` panics #46133 (closed)

Related Code Changes

• crypto/internal/fips140/edwards25519/field/_asm: update avo dependency

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/712920 mentions this issue: crypto/internal/fips140/aes: fix CTR generator

[dr2chase]

@FiloSottile @rolandshoemaker @golang/security