proposal: cmd/gofmt: also exit 1 for `-l` (list paths)

[thejcannon]

Proposal Details

👋 Howdy!

I'm very excited to see #46289 fixed/merged 🎉

Can we extend that niceness to -l?

There's some prior art...

# Prettier
$ prettier --list-different bad.json; echo $?
bad.json
1
$ prettier --list-different good.json; echo $?
0

# Rustfmt
$ rustfmt --check --files-with-diff bad.rs; echo $?
/abs/path/to/bad.rs
1
$ rustfmt --check --files-with-diff good.rs; echo $?
0

# OpenTofu
$ tofu fmt --check bad.tf; echo $?
bad.tf
3
$ tofu fmt --check good.rs; echo $?
0

[gabyhelp]

Related Issues

• proposal: cmd/fmt: flag to set exit code when formatting occurs #24427 (closed)
• proposal: cmd/gofmt: add a flag to make incorrect formatting return a non-zero exit code #74907 (closed)
• proposal: cmd/gofmt: add a flag to return an error exit status. #45953 (closed)
• cmd/gofmt: change -d to exit 1 if diffs exist #46289 (closed)
• x/tools/cmd/goimports: return non-zero exit code if there's an offense #39032 (closed)
• Proposal: Allow gofmt to return non-zero if code violations are found #24230 (closed)
• Proposal: Allow go fmt to return non-zero if code violations are found #41189 (closed)
• "gofmt -d" should have non-zero exit if there is a diff #38551 (closed)
• x/tools/gopls: set non-zero exit code on `check` command when there are errors #67078

Related Code Changes

• cmd/gofmt: add -x flag to get an error exit status.

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}