strings: update Join parameter name for clarity

[zsiec]

No description provided.

[gopherbot]

This PR (HEAD: 35476de) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/211799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

Thanks, but they aren't missing words. The word "a" refers to the parameter of that name.

If we want to change something here, perhaps we should change the name of the parameter to make this clearer.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: ea4f3df) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/211799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Thomas Symborski:

Patch Set 1:

Patch Set 1:

Thanks, but they aren't missing words. The word "a" refers to the parameter of that name.

If we want to change something here, perhaps we should change the name of the parameter to make this clearer.

Makes sense, apologies, missed that! I've updated my CR with your suggestion.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Thomas Symborski:

Patch Set 4:

(1 comment)

Patch Set 3:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 4:

Does the c stand for clarity? Do we use c for a slice of string anywhere else? I think as would be more common.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 944eeaf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/211799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Thomas Symborski:

Patch Set 4:

Patch Set 4:

Does the c stand for clarity? Do we use c for a slice of string anywhere else? I think as would be more common.

c was a random pick, if there's precedent using 'as' let's use that. updated the CR

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Rob Pike:

Patch Set 5:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Thomas Symborski:

Patch Set 5:

(1 comment)

Patch Set 5:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: cdec672) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/211799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: ee82eaa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/211799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Thomas Symborski:

Patch Set 7:

(1 comment)

Patch Set 5:

(1 comment)

Patch Set 5:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 7: Run-TryBot+1 Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9bdf90e1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/211799.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/211799 has been merged.