Skip to content

Conversation

@yah01
Copy link
Contributor

@yah01 yah01 commented Jan 14, 2020

Fixes #36520

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 14, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: c7cdcf0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/214821 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

@yah01 yah01 changed the title fix #36520 issue spec: add missing space in EBNF Jan 15, 2020
@gopherbot
Copy link
Contributor

Message from yah01:

Patch Set 3:

(1 comment)

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 3:

(1 comment)

LGTM but please up-date the timestamp in the beginning


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 368a1dc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/214821 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from yah01:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 15, 2020
Fixes #36520

Change-Id: I698ab235f82f7c81caa09318c954847cf3833153
GitHub-Last-Rev: 368a1dc
GitHub-Pull-Request: #36559
Reviewed-on: https://go-review.googlesource.com/c/go/+/214821
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 4: Code-Review+2

Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/214821.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/214821 has been merged.

@gopherbot gopherbot closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: go-spec.html missing space before . on line 2416, OperandName = identifier | QualifiedIdent.

3 participants