-
Notifications
You must be signed in to change notification settings - Fork 18.5k
net/udpsock: exposes contexts for several UPD related functions #59880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/udpsock: exposes contexts for several UPD related functions #59880
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
d4f9a04 to
2203a0b
Compare
|
This PR (HEAD: 2203a0b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/490195 to see it. Tip: You can toggle comments from me using the |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/490195. |
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490195. |
|
Message from Ian Lance Taylor: Patch Set 2: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490195. |
2203a0b to
308b4bb
Compare
|
This PR (HEAD: 308b4bb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/490195 to see it. Tip: You can toggle comments from me using the |
308b4bb to
69e8291
Compare
|
This PR (HEAD: 69e8291) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/490195 to see it. Tip: You can toggle comments from me using the |
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/490195. |
udpsockpackage several (exposed) functions usecontext.Background()as context for calls to unexposed internal functions.This PR relates to proposal: #59897
TODO
Please review the function documention and suggest changes to adhere closer to the usual documention.