Skip to content

Conversation

@milkpirate
Copy link

@milkpirate milkpirate commented Apr 28, 2023

  • In the udpsock package several (exposed) functions use context.Background() as context for calls to unexposed internal functions.
  • This PR makes it possible for the user to hand over its own context to the internal functions.
  • This makes it possible to e.g. cancel or timeout specific UDP interactions

This PR relates to proposal: #59897

TODO

Please review the function documention and suggest changes to adhere closer to the usual documention.

@google-cla
Copy link

google-cla bot commented Apr 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@milkpirate milkpirate force-pushed the feat/net/udpsock-exposecontexts branch from d4f9a04 to 2203a0b Compare April 28, 2023 10:12
@milkpirate milkpirate marked this pull request as ready for review April 28, 2023 10:12
@gopherbot
Copy link
Contributor

This PR (HEAD: 2203a0b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/490195 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/490195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490195.
After addressing review feedback, remember to publish your drafts!

@milkpirate milkpirate force-pushed the feat/net/udpsock-exposecontexts branch from 2203a0b to 308b4bb Compare April 29, 2023 08:30
@gopherbot
Copy link
Contributor

This PR (HEAD: 308b4bb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/490195 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@milkpirate milkpirate force-pushed the feat/net/udpsock-exposecontexts branch from 308b4bb to 69e8291 Compare May 2, 2023 16:55
@gopherbot
Copy link
Contributor

This PR (HEAD: 69e8291) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/490195 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490195.
After addressing review feedback, remember to publish your drafts!

@seankhliao seankhliao closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants