net/http/cgi: the PATH_INFO should be empty or start with a slash #63926

aimuz · 2023-11-03T08:01:31Z

fixed PATH_INFO not starting with a slash as described in RFC 3875
for PATH_INFO.

Fixes #63925

gopherbot · 2023-11-03T08:07:15Z

This PR (HEAD: de79aa7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/539615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-03T08:14:14Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T08:14:15Z

Message from Aimuz me:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T08:21:09Z

Message from Aimuz me:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:19:11Z

Message from Bryan Mills:

Patch Set 2: Code-Review+1 Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:27:08Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-03T14:13:04Z","revision":"d43f6c2e9f725b41cc98a0664af109cc98c7b87d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:35:17Z

Message from Bryan Mills:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:35:17Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:35:18Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:43:41Z

This PR (HEAD: 2fccfd4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/539615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-03T14:51:42Z

Message from Aimuz me:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:51:43Z

Message from Bryan Mills:

Patch Set 3: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T14:59:56Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-03T14:45:08Z","revision":"17098ee8d2d9c2687d7c17c04778456a495f0d29"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T15:08:26Z

Message from Bryan Mills:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T15:08:27Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T15:08:28Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T15:16:46Z

Message from raghvender sundarjee:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T15:33:15Z

Message from Bryan Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T16:05:14Z

Message from Damien Neil:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-03T16:42:37Z

Message from raghvender sundarjee:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

Fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO Fixes golang#63925

gopherbot · 2023-11-03T23:42:27Z

This PR (HEAD: 1c532e3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/539615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-06T21:57:33Z

Message from Damien Neil:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T21:57:34Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-06T21:46:57Z","revision":"284ac497fa89b1a0d8cc81da1810393c2c376f49"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T21:57:35Z

Message from Bryan Mills:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539615.
After addressing review feedback, remember to publish your drafts!

fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO. Fixes #63925 Change-Id: I1ead98dff190c53eb7a50546569ef6ded3199a0a GitHub-Last-Rev: 1c532e3 GitHub-Pull-Request: #63926 Reviewed-on: https://go-review.googlesource.com/c/go/+/539615 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2023-11-06T22:12:14Z

This PR is being closed because golang.org/cl/539615 has been merged.

aimuz changed the title ~~net/http/cgi: PATH_INFO should be empty or start with a slash~~ net/http/cgi: the PATH_INFO should be empty or start with a slash Nov 3, 2023

aimuz force-pushed the fix-63925 branch from de79aa7 to 2fccfd4 Compare November 3, 2023 14:41

net/http/cgi: PATH_INFO should be empty or start with a slash

1c532e3

Fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO Fixes golang#63925

aimuz force-pushed the fix-63925 branch from 2fccfd4 to 1c532e3 Compare November 3, 2023 23:38

gopherbot closed this Nov 6, 2023

net/http/cgi: the PATH_INFO should be empty or start with a slash #63926

net/http/cgi: the PATH_INFO should be empty or start with a slash #63926

Uh oh!

Conversation

aimuz commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 3, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

gopherbot commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aimuz commented Nov 3, 2023 •

edited

Loading