-
Notifications
You must be signed in to change notification settings - Fork 18.4k
all: eliminate unnecessary type conversions #75974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 28fcffe) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712940. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jes Cok: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-19T18:28:07Z","revision":"9085f2dcee5ddb32ddf69c375d452efd0ce2fe6b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jes Cok: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_avx512-greenteagc has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
28fcffe
to
3b0f7e8
Compare
This PR (HEAD: 3b0f7e8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712940. Important tips:
|
Message from Jes Cok: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-19T19:55:47Z","revision":"7377e28a52fb1c1a10e747d35d48308a96dd9085"} Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jorropo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Jes Cok: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712940. |
Found by github.com/mdempsky/unconvert Change-Id: I88ce10390a49ba768a4deaa0df9057c93c1164de GitHub-Last-Rev: 3b0f7e8 GitHub-Pull-Request: #75974 Reviewed-on: https://go-review.googlesource.com/c/go/+/712940 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com>
This PR is being closed because golang.org/cl/712940 has been merged. |
Found by github.com/mdempsky/unconvert