Skip to content

time: rewrite IsZero method to use wall and ext fields #76006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+5 −1
Closed

time: rewrite IsZero method to use wall and ext fields #76006

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c28f8cd
Refactor IsZero method to use wall and ext fields
dxasu Oct 22, 2025
49771b9
Clarify IsZero method with additional comment
dxasu Oct 24, 2025
269b1b8
Enhance IsZero method comments for clarity and efficiency
dxasu Oct 27, 2025
4a91948
Rewrite comments in IsZero function for clarity
dxasu Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/time/time.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ func (t *Time) mono() int64 {
// IsZero reports whether t represents the zero time instant,
// January 1, year 1, 00:00:00 UTC.
func (t Time) IsZero() bool {
return t.sec() == 0 && t.nsec() == 0
// If hasMonotonic is set in t.wall, then the time can't be before 1885, so it can't be the year 1.
// If hasMonotonic is zero, then all the bits in wall other than the nanoseconds field should be 0.
// So if there are no nanoseconds then t.wall == 0, and if there are no seconds then t.ext == 0.
// This is equivalent to t.sec() == 0 && t.nsec() == 0, but is more efficient.
return t.wall == 0 && t.ext == 0
}

// After reports whether the time instant t is after u.
Expand Down