internal/importpath: extract shared import path validation logic #76322
+66
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the duplicated import path validation logic
I created a new package: internal/importpath.
I've only refactored one call site so reviewers can validate my approach
and package placement before I proceed with the remaining sites.
I've placed it under internal/ but that doesn't seem correct.
The code is failing the TestDependencies test.
The remaining call sites are: go/build/read.go, go/printer/nodes.go,
go/types/resolver.go, cmd/go/internal/load/pkg.go,
cmd/compile/internal/types2/resolver.go.
Updates #74446