Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Comments

add line break in for reflect vendoring error#577

Merged
codyoss merged 1 commit intogolang:masterfrom
sanposhiho:add-line-break
Sep 17, 2021
Merged

add line break in for reflect vendoring error#577
codyoss merged 1 commit intogolang:masterfrom
sanposhiho:add-line-break

Conversation

@sanposhiho
Copy link
Contributor

@sanposhiho sanposhiho commented Jun 18, 2021

Hi. Sorry for very minor change. 😢

The link on error message was not clear because there was no line break, so this PR fixes it.

Some IDE shows link like this. (This pic is GoLand)
This may confuse users.
スクリーンショット 2021-06-18 11 45 40

@sanposhiho sanposhiho requested a review from codyoss as a code owner June 18, 2021 02:52
@sanposhiho sanposhiho changed the title Add: add line break Add: add line break on error message Jun 18, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@codyoss codyoss changed the title Add: add line break on error message add line break in for vendoring error Sep 17, 2021
@codyoss codyoss changed the title add line break in for vendoring error add line break in for reflect vendoring error Sep 17, 2021
@codyoss codyoss merged commit 40d81f1 into golang:master Sep 17, 2021
sryoya pushed a commit to sryoya/mock that referenced this pull request Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants