http2: add DialTLSContext to Transport #123

Dreamacro · 2022-01-10T09:57:42Z

gopherbot · 2022-01-10T09:59:52Z

This PR (HEAD: 99826fe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/377114 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-01-10T10:03:29Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-01-10T10:10:28Z

This PR (HEAD: 6549be1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/377114 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-01-10T10:29:05Z

This PR (HEAD: 0a61bce) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/377114 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

francislavoie · 2022-02-04T06:34:29Z

I think this would fix golang/go#50392

francislavoie · 2022-03-09T03:11:00Z

@neild @tombergan I hate to be a bother, but could we get a review here? Caddy has some users that are blocked by this function missing. Thanks!

gopherbot · 2022-04-01T23:48:59Z

Message from Damien Neil:

Patch Set 3: Run-TryBot+1 Trust+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-01T23:52:20Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-01T23:52:20Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-02T04:31:38Z

This PR (HEAD: 8e4df14) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/377114 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-04-02T04:38:11Z

Message from Dreamacro chen:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-05T02:50:32Z

Message from Dreamacro chen:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-16T17:57:19Z

Message from Damien Neil:

Patch Set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-16T17:57:20Z

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-16T18:05:00Z

Message from Damien Neil:

Patch Set 6: Run-TryBot+1 -Code-Review

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-16T18:12:42Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-16T18:12:43Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-17T02:08:56Z

Message from Dreamacro chen:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-17T05:10:29Z

Message from Dreamacro chen:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Dreamacro <chuainian@gmail.com>

gopherbot · 2022-05-17T05:23:05Z

This PR (HEAD: 488673b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/377114 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-06-21T05:22:35Z

Message from Dreamacro chen:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-21T22:15:03Z

Message from Ian Lance Taylor:

Patch Set 9: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-21T22:19:19Z

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-21T22:23:28Z

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T02:30:48Z

Message from Dreamacro chen:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

Fixes golang/go#52114 Change-Id: Ibc0ba6b401bb39ea89f88796d55fbf781596140e GitHub-Last-Rev: 488673b GitHub-Pull-Request: #123 Reviewed-on: https://go-review.googlesource.com/c/net/+/377114 Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com>

gopherbot · 2022-08-12T16:57:02Z

Message from Damien Neil:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/377114.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-12T17:01:35Z

This PR is being closed because golang.org/cl/377114 has been merged.

Fixes golang/go#52114 Change-Id: Ibc0ba6b401bb39ea89f88796d55fbf781596140e GitHub-Last-Rev: 488673bebeca2cc9d79328cc348ac1014096b697 GitHub-Pull-Request: golang/net#123 Reviewed-on: https://go-review.googlesource.com/c/net/+/377114 Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com>

ghost mentioned this pull request Feb 17, 2022

Does reverse_proxy handler support proxying H2C traffic to a UDS? caddyserver/caddy#4498

Closed

francislavoie mentioned this pull request Mar 9, 2022

Add h2c support for an upstream caddyserver/caddy#3218

Closed

Dreamacro mentioned this pull request Apr 2, 2022

x/net/http2: add DialTLSContext to Transport golang/go#52114

Closed

http2: add DialTLSContext to Transport

488673b

Signed-off-by: Dreamacro <chuainian@gmail.com>

WeidiDeng mentioned this pull request Jul 25, 2022

h2c server allows graceful shutdown caddyserver/caddy#4907

Open

gopherbot closed this Aug 12, 2022

Uh oh!

http2: add DialTLSContext to Transport #123

http2: add DialTLSContext to Transport #123

Uh oh!

Conversation

Dreamacro commented Jan 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jan 10, 2022

Uh oh!

gopherbot commented Jan 10, 2022

Uh oh!

gopherbot commented Jan 10, 2022

Uh oh!

gopherbot commented Jan 10, 2022

Uh oh!

francislavoie commented Feb 4, 2022

Uh oh!

francislavoie commented Mar 9, 2022

Uh oh!

gopherbot commented Apr 1, 2022

Uh oh!

gopherbot commented Apr 1, 2022

Uh oh!

gopherbot commented Apr 1, 2022

Uh oh!

gopherbot commented Apr 2, 2022

Uh oh!

gopherbot commented Apr 2, 2022

Uh oh!

gopherbot commented May 5, 2022

Uh oh!

gopherbot commented May 16, 2022

Uh oh!

gopherbot commented May 16, 2022

Uh oh!

gopherbot commented May 16, 2022

Uh oh!

gopherbot commented May 16, 2022

Uh oh!

gopherbot commented May 16, 2022

Uh oh!

gopherbot commented May 17, 2022

Uh oh!

gopherbot commented May 17, 2022

Uh oh!

gopherbot commented May 17, 2022

Uh oh!

gopherbot commented Jun 21, 2022

Uh oh!

gopherbot commented Jun 21, 2022

Uh oh!

gopherbot commented Jun 21, 2022

Uh oh!

gopherbot commented Jun 21, 2022

Uh oh!

gopherbot commented Aug 3, 2022

Uh oh!

gopherbot commented Aug 12, 2022

Uh oh!

gopherbot commented Aug 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dreamacro commented Jan 10, 2022 •

edited

Loading