Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: add DialTLSContext to Transport #52114

Open
Dreamacro opened this issue Apr 2, 2022 · 6 comments · May be fixed by golang/net#123
Open

x/net/http2: add DialTLSContext to Transport #52114

Dreamacro opened this issue Apr 2, 2022 · 6 comments · May be fixed by golang/net#123

Comments

@Dreamacro
Copy link

@Dreamacro Dreamacro commented Apr 2, 2022

net.Transport contains DialContext, but http2.Transport only contains DialTLS, so a similar DialTLSContext has been added to make http.Transport support context.

What's changed:

https://github.com/golang/net/blob/8e4df14915a2b0bef8fb1a2d5f67f1bcedc6ab31/http2/transport.go#L66-L88

This proposal only adds a new API, so there is no breaking change.

ref:
golang/net#123
https://go-review.googlesource.com/c/net/+/377114

@gopherbot gopherbot added this to the Proposal milestone Apr 2, 2022
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 6, 2022

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals Apr 6, 2022
@rsc
Copy link
Contributor

@rsc rsc commented Apr 13, 2022

It seems like we clearly need DialTLSContext given that it's already in http.Transport.

@rsc
Copy link
Contributor

@rsc rsc commented Apr 13, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Incoming to Likely Accept in Proposals Apr 13, 2022
@rsc rsc moved this from Likely Accept to Accepted in Proposals May 4, 2022
@rsc
Copy link
Contributor

@rsc rsc commented May 4, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: x/net/http2: add DialTLSContext to Transport x/net/http2: add DialTLSContext to Transport May 4, 2022
@rsc rsc removed this from the Proposal milestone May 4, 2022
@rsc rsc added this to the Backlog milestone May 4, 2022
@francislavoie
Copy link

@francislavoie francislavoie commented May 5, 2022

FYI #50392 is a duplicate (rather, was written first, but the PR and this issue were written after without linking to it)

@gopherbot
Copy link

@gopherbot gopherbot commented May 16, 2022

Change https://go.dev/cl/377114 mentions this issue: http2: add DialTLSContext to Transport

@Dreamacro Dreamacro linked a pull request May 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Accepted
Development

Successfully merging a pull request may close this issue.

5 participants