jwt: support PrivateClaims in Config #374

wlhee · 2019-03-08T07:35:01Z

This would help add extra claim for certain 2-leg JWT exchange.

For example, Google service account key can be used to generate an OIDC token, but Google TokenURL requires "target_audience" claims set.

See this example usage:
https://gist.github.com/wlhee/64bc518190053e2122ca1909c2977c67#file-exmaple-go-L29

gopherbot · 2019-03-08T07:50:49Z

This PR (HEAD: 8baca54) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T15:56:38Z

Message from Brad Fitzpatrick:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T15:56:38Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T17:22:15Z

This PR (HEAD: 339f364) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T23:09:57Z

This PR (HEAD: b33c8d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T23:12:28Z

Message from Wenlei He:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

marwan-at-work · 2019-03-21T18:39:40Z

Any luck here? Thanks!

gopherbot · 2019-04-04T16:42:50Z

Message from Brad Fitzpatrick:

Patch Set 4:

(4 comments)

Sorry, I don't know much about this subject matter.

I can only review documentation & tests.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T16:45:40Z

Message from Brad Fitzpatrick:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T16:45:41Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e49cf9ad

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T16:48:22Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-14T22:12:34Z

This PR (HEAD: a5a809a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

wlhee · 2019-04-14T22:14:03Z

PR updated.

marwan-at-work · 2019-05-15T18:34:03Z

@wlhee any luck with this PR? Thanks

wlhee · 2019-05-16T03:32:58Z

I will ping the review again... It's been too long :(

…

On Wed, May 15, 2019 at 11:34 AM Marwan Sulaiman ***@***.***> wrote: @wlhee <https://github.com/wlhee> any luck with this PR? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#374?email_source=notifications&email_token=ABGGYABX4UOXGELLZTXD4CLPVRJSDA5CNFSM4G4TIMA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPRZCY#issuecomment-492772491>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGGYAC5PZGFXNHGG3OPPGDPVRJSDANCNFSM4G4TIMAQ> .

gopherbot · 2019-05-17T17:33:05Z

Message from Brad Fitzpatrick:

Patch Set 5: Code-Review+1

(4 comments)

I'll trust you on the subject matter, so this is fine after I you fix up this last round on the docs.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

…ken. Updated comments.

gopherbot · 2019-05-17T17:52:32Z

This PR (HEAD: ac8ecd8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-05-17T17:57:01Z

This PR (HEAD: 7a6e247) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/166220 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-05-17T17:59:10Z

Message from Wenlei He:

Patch Set 7:

(4 comments)

Patch Set 5: Code-Review+1

(4 comments)

I'll trust you on the subject matter, so this is fine after I you fix up this last round on the docs.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-05-17T18:07:05Z

Message from Brad Fitzpatrick:

Patch Set 7: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-05-17T18:07:06Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=329f336d

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-05-17T18:08:16Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166220.
After addressing review feedback, remember to publish your drafts!

This would help add extra claim for certain 2-leg JWT exchange. For example, Google service account key can be used to generate an OIDC token, but Google TokenURL requires "target_audience" claims set. See this example usage: https://gist.github.com/wlhee/64bc518190053e2122ca1909c2977c67#file-exmaple-go-L29 Change-Id: Ic10b006e45a34210634c5a76261a7e3706066965 GitHub-Last-Rev: 7a6e247 GitHub-Pull-Request: #374 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/166220 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot · 2019-05-17T18:14:08Z

This PR is being closed because golang.org/cl/166220 has been merged.

wlhee added 2 commits March 7, 2019 22:22

Add optional PrivateClaims to jwt.Config

9dd27cc

Test PrivateClaims support in jwt.go.

8baca54

googlebot added the cla: yes label Mar 8, 2019

bradfitz changed the title ~~Support PrivateClaims in jwt.Config~~ jwt: support PrivateClaims in Config Mar 8, 2019

Support using ID token as the ouath access token.

339f364

Updated comments and format.

b33c8d1

jprobinson mentioned this pull request Mar 21, 2019

Adding google identity auth + updating to go 1.12/Modules nytimes/drone-openapi#2

Merged

Update docs in jwt.go.

a5a809a

Returns error when UseIDToken is true but response doesn't have ID to…

ac8ecd8

…ken. Updated comments.

Update print format in jwt_test.go.

7a6e247

gopherbot closed this May 17, 2019

jwt: support PrivateClaims in Config #374

jwt: support PrivateClaims in Config #374

Uh oh!

Conversation

wlhee commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

gopherbot commented Mar 8, 2019

Uh oh!

marwan-at-work commented Mar 21, 2019

Uh oh!

gopherbot commented Apr 4, 2019

Uh oh!

gopherbot commented Apr 4, 2019

Uh oh!

gopherbot commented Apr 4, 2019

Uh oh!

gopherbot commented Apr 4, 2019

Uh oh!

gopherbot commented Apr 14, 2019

Uh oh!

wlhee commented Apr 14, 2019

Uh oh!

marwan-at-work commented May 15, 2019

Uh oh!

wlhee commented May 16, 2019 via email

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

gopherbot commented May 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants