-
Notifications
You must be signed in to change notification settings - Fork 1k
endpoints: add new package for oauth2.Endpoint values #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As per discussion in golang#401 and gerrit I have built out the proposed endpoint package. I migrated all the existing endpoints, not sure if you wanted this but it does illustrate the pattern.
|
This PR (HEAD: 438f07c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/212223 to see it. Tip: You can toggle comments from me using the |
|
Message from Brad Fitzpatrick: Patch Set 2: (7 comments) Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/212223. |
|
This PR (HEAD: 4a1d3a6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/212223 to see it. Tip: You can toggle comments from me using the |
|
Message from Brad Fitzpatrick: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/212223. |
|
This PR (HEAD: fde9e7b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/212223 to see it. Tip: You can toggle comments from me using the |
|
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/212223. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=b0e20f88 Please don’t reply on this GitHub thread. Visit golang.org/cl/212223. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/212223. |
As per discussion in #401 and gerrit I have built out the proposed endpoint package. I migrated all the existing endpoints, not sure if you wanted this but it does illustrate the pattern. Change-Id: I53f56a06207633b2380b7cd7332cd56f9ef6578f GitHub-Last-Rev: fde9e7b GitHub-Pull-Request: #402 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/212223 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/212223 has been merged. |
As per discussion in #401 and gerrit I have built out the proposed endpoint package.
I migrated all the existing endpoints, not sure if you wanted this but it does illustrate the pattern.