authhandler: Add support for 3-legged-OAuth #419

andyrzhao · 2020-05-06T00:18:57Z

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler.

Added example_test.go with a sample command line implementation for AuthorizationHandler.

This patch adds support for 3-legged-OAuth flow using an OAuth Client ID file downloaded from Google Cloud Console.

Add OAuthClientTokenSource in google/google.go Add DefaultAuthorizationHandler in authhandler.go

gopherbot · 2020-05-06T00:35:17Z

This PR (HEAD: ceaa866) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-05-06T00:36:33Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-28T23:15:58Z

Message from Chris Broadfoot:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-28T23:15:59Z

Message from Chris Broadfoot:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-28T23:15:59Z

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5ccda342

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-28T23:17:23Z

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-05T05:32:38Z

This PR (HEAD: 04f020b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-15T03:53:48Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:49Z

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5ccda342

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:49Z

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler. Added default_authhandler.go to provide a command line implementation for AuthorizationHandler.

gopherbot · 2021-03-09T22:12:51Z

This PR (HEAD: 1105999) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-10T20:03:39Z

Message from Shin Fan:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-10T20:03:39Z

Message from Shin Fan:

Patch Set 5: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-10T20:03:40Z

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=49eca181

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-10T20:03:41Z

Message from Go Bot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-11T15:01:51Z

Message from Tyler Bui-Palsulich:

Patch Set 5:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-11T15:04:11Z

Message from Tyler Bui-Palsulich:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T05:24:19Z

This PR (HEAD: cde11fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-12T05:38:24Z

This PR (HEAD: 7c28922) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-12T05:56:35Z

Message from Andy Zhao:

Patch Set 7:

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T14:56:45Z

Message from Cody Oss:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T20:46:22Z

This PR (HEAD: 8a926e1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T21:07:37Z

Message from Andy Zhao:

Patch Set 8:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-17T19:13:42Z

Message from Cody Oss:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-17T19:30:50Z

This PR (HEAD: ab12fee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-17T19:32:54Z

Message from Andy Zhao:

Patch Set 10:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-17T19:36:59Z

Message from Cody Oss:

Patch Set 10: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-17T19:37:00Z

Message from Go Bot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=82950d3a

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-17T19:39:02Z

Message from Go Bot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

…tead

gopherbot · 2021-03-18T16:16:25Z

This PR (HEAD: fcaf078) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-18T16:34:45Z

Message from Andy Zhao:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-19T17:16:37Z

Message from Tyler Bui-Palsulich:

Patch Set 12:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-19T19:10:05Z

This PR (HEAD: 48fc036) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/232238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-19T19:22:15Z

Message from Andy Zhao:

Patch Set 13:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-23T16:26:44Z

Message from Tyler Bui-Palsulich:

Patch Set 13: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler. Added example_test.go with a sample command line implementation for AuthorizationHandler. This patch adds support for 3-legged-OAuth flow using an OAuth Client ID file downloaded from Google Cloud Console. Change-Id: Iefe54494d6f3ee326a6b1b2a81a7d5d1a7ba3331 GitHub-Last-Rev: 48fc036 GitHub-Pull-Request: #419 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/232238 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: Shin Fan <shinfan@google.com> Reviewed-by: Cody Oss <codyoss@google.com> Trust: Shin Fan <shinfan@google.com> Trust: Cody Oss <codyoss@google.com>

gopherbot · 2021-03-23T18:10:42Z

Message from Shin Fan:

Patch Set 13: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232238.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-23T18:12:44Z

This PR is being closed because golang.org/cl/232238 has been merged.

google: Add support for 3-legged-OAuth using OAuth Client ID

ceaa866

Add OAuthClientTokenSource in google/google.go Add DefaultAuthorizationHandler in authhandler.go

googlebot added the cla: yes label May 6, 2020

google: Make state configurable in DefaultAuthorizationHandler

04f020b

authhandler: Add support for 3-legged-OAuth

1105999

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler. Added default_authhandler.go to provide a command line implementation for AuthorizationHandler.

andyrzhao changed the title ~~google: Add support for 3-legged-OAuth using OAuth Client ID~~ authhandler: Add support for 3-legged-OAuth Mar 9, 2021

authhandler: Add authhandler_test.go

cde11fb

authhandler: Update default_authhandler.go to inline handler logic

7c28922

authhandler: Rename to CmdAuthorizationHandler and add example_test.go

8a926e1

authhandler: Make authHandler the last parameter

ab12fee

authhandler: Remove CmdAuthorizationHandler and use it as example ins…

fcaf078

…tead

andyrzhao added 2 commits March 19, 2021 11:49

authhandler: Reword comment regarding state

1ae3746

authhandler: Reword comment regarding state in example

48fc036

gopherbot closed this Mar 23, 2021

authhandler: Add support for 3-legged-OAuth #419

authhandler: Add support for 3-legged-OAuth #419

Uh oh!

Conversation

andyrzhao commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented May 6, 2020

Uh oh!

gopherbot commented May 6, 2020

Uh oh!

gopherbot commented May 28, 2020

Uh oh!

gopherbot commented May 28, 2020

Uh oh!

gopherbot commented May 28, 2020

Uh oh!

gopherbot commented May 28, 2020

Uh oh!

gopherbot commented Jun 5, 2020

Uh oh!

gopherbot commented Oct 15, 2020

Uh oh!

gopherbot commented Oct 15, 2020

Uh oh!

gopherbot commented Oct 15, 2020

Uh oh!

gopherbot commented Mar 9, 2021

Uh oh!

gopherbot commented Mar 10, 2021

Uh oh!

gopherbot commented Mar 10, 2021

Uh oh!

gopherbot commented Mar 10, 2021

Uh oh!

gopherbot commented Mar 10, 2021

Uh oh!

gopherbot commented Mar 11, 2021

Uh oh!

gopherbot commented Mar 11, 2021

Uh oh!

gopherbot commented Mar 12, 2021

Uh oh!

gopherbot commented Mar 12, 2021

Uh oh!

gopherbot commented Mar 12, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 17, 2021

Uh oh!

gopherbot commented Mar 18, 2021

Uh oh!

gopherbot commented Mar 18, 2021

Uh oh!

gopherbot commented Mar 19, 2021

Uh oh!

gopherbot commented Mar 19, 2021

Uh oh!

gopherbot commented Mar 19, 2021

Uh oh!

gopherbot commented Mar 23, 2021

Uh oh!

gopherbot commented Mar 23, 2021

Uh oh!

gopherbot commented Mar 23, 2021

andyrzhao commented May 6, 2020 •

edited

Loading