google: add ExchangeToken() to run STS exchanges. #444

gIthuriel · 2020-10-13T19:06:10Z

Adds the ExchangeToken() function and support structs, but depends on #439

gopherbot · 2020-10-13T19:24:17Z

This PR (HEAD: 8ea3602) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

renkelvin · 2020-10-13T20:16:30Z

google/internal/oauth/stsExchange_test.go

+
+
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if diff := cmp.Diff(*r, serverReq); diff != "" {


Instead of comparing the whole requests, you can compare each fields like

oauth2/oauth2_test.go

Line 101 in 5d25da1

headerAuth := r.Header.Get("Authorization")

gopherbot · 2020-10-19T21:39:02Z

This PR (HEAD: b838bba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-19T21:40:59Z

This PR (HEAD: 7f24b84) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-19T21:51:16Z

This PR (HEAD: ddbe2ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-19T21:56:25Z

This PR (HEAD: c19137f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-19T22:18:41Z

This PR (HEAD: 13049af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-03T15:16:19Z

Message from Cody Oss:

Patch Set 7:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

Change-Id: If664a760005cc209c7398f2efce5ff324ebc4746

gopherbot · 2020-11-03T21:45:02Z

This PR (HEAD: 717b310) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-03T21:46:53Z

Message from Patrick Jones:

Patch Set 7:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T23:22:51Z

Message from Cody Oss:

Patch Set 9:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T23:33:22Z

Message from Patrick Jones:

Patch Set 7:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T23:33:22Z

Message from Cody Oss:

Patch Set 9:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

Change-Id: Idafbe36f4add6998e57878fec84a1080ac962511

gopherbot · 2020-11-03T23:38:44Z

Message from Patrick Jones:

Patch Set 9:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T23:38:48Z

This PR (HEAD: 4bcf502) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-12-02T17:12:12Z

Message from Go Bot:

Patch Set 17:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/3d913a92/freebsd-amd64-12_0_2c8f2d84.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-02T17:14:13Z

Message from Go Bot:

Patch Set 17: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261918.
After addressing review feedback, remember to publish your drafts!

google: add utilities supporting upcoming oauth2 functionality

Change-Id: If664a760005cc209c7398f2efce5ff324ebc4746

Change-Id: Idafbe36f4add6998e57878fec84a1080ac962511

Change-Id: I9c45c7848de4ab2e3a685f761c85b1c9405b6eb1

Change-Id: Id2cd28484e3724eee98757c2f40cbb237dee2c75

Change-Id: Idc322fc66cb93e5d61f0c41d5847a2567a5e1019

Change-Id: I189302ad4f49a206dd298b767a827b0263df8c43

Change-Id: I00cb6cf668073883c96ac0144847fa2693414044

Change-Id: I54d2702a149d1eccd64f8ef2ed4b4617429c9358

Change-Id: Ifc55814018bf66d2e77752d770a51c716376cabc

Change-Id: Iefbf394e5aa3bc69b5a82ec861b1b4a2b21c941a

Change-Id: I0f775143be9f66e80b3a0bc0ecf92952f41a8cd1

google-cla · 2020-12-02T23:43:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

gopherbot · 2020-12-02T23:44:02Z

This PR (HEAD: 1aa066d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/261918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Adds the ExchangeToken() function and support structs, but depends on #439 Change-Id: Id738a27b0c2ac083409156af1f60283b9140b159 GitHub-Last-Rev: 1aa066d GitHub-Pull-Request: #444 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/261918 Run-TryBot: Tyler Bui-Palsulich <tbp@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Tyler Bui-Palsulich <tbp@google.com> Trust: Cody Oss <codyoss@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

gIthuriel · 2021-08-16T01:38:49Z

Change was successfully cherry-picked on December 2, 2020; this PR was simply left over. Closing now.

gIthuriel added 2 commits October 13, 2020 12:02

Draft showing WIP testing approach.

9ed4d33

Tweaked some internal notes

8ea3602

google-cla bot added the cla: yes label Oct 13, 2020

renkelvin reviewed Oct 13, 2020

View reviewed changes

gIthuriel added 2 commits October 19, 2020 13:43

temp

58b935b

Add testing for ExchangeToken()

b838bba

Go fmt

7f24b84

gIthuriel marked this pull request as ready for review October 19, 2020 21:43

Fixed file names.

ddbe2ba

Fixed directory structure.

c19137f

Fixed import issues and test validity.

13049af

gIthuriel changed the title ~~Draft showing WIP testing approach~~ TokenExchange functionality, dependent on #439 Oct 19, 2020

google: add ExchangeToken unit tests

ed1c7b8

google: fix error formatting, add ctx argument

717b310

Change-Id: If664a760005cc209c7398f2efce5ff324ebc4746

gIthuriel changed the title ~~TokenExchange functionality, dependent on #439~~ google: add ExchangeToken() to run STS exchanges. Nov 3, 2020

google: fix more nits and return early in one error case.

4bcf502

Change-Id: Idafbe36f4add6998e57878fec84a1080ac962511

gIthuriel and others added 21 commits December 2, 2020 15:30

Merge pull request #1 from golang/master

532f2de

google: add utilities supporting upcoming oauth2 functionality

Draft showing WIP testing approach.

358bcd3

Tweaked some internal notes

2522fa4

temp

f5cea3e

Add testing for ExchangeToken()

9f31b34

Go fmt

3231799

Fixed file names.

da03451

Fixed directory structure.

cde1045

Fixed import issues and test validity.

520fe12

google: add ExchangeToken unit tests

5688b03

google: fix error formatting, add ctx argument

01ea637

Change-Id: If664a760005cc209c7398f2efce5ff324ebc4746

google: fix more nits and return early in one error case.

801e561

Change-Id: Idafbe36f4add6998e57878fec84a1080ac962511

google: update formatting and code structure

5908a54

Change-Id: I9c45c7848de4ab2e3a685f761c85b1c9405b6eb1

google: update error return format.

57d1f92

Change-Id: Id2cd28484e3724eee98757c2f40cbb237dee2c75

google: change json decoding layout

ccc73e0

Change-Id: Idc322fc66cb93e5d61f0c41d5847a2567a5e1019

google: remove remaining cmp.Diff call

97d4314

Change-Id: I189302ad4f49a206dd298b767a827b0263df8c43

google: add test to ensure optional field works as intended.

b1b1e51

Change-Id: I00cb6cf668073883c96ac0144847fa2693414044

google: clean up tests and add godoc comments

aa7010a

Change-Id: I54d2702a149d1eccd64f8ef2ed4b4617429c9358

google: fix spelling and go fmt

a17de82

Change-Id: Ifc55814018bf66d2e77752d770a51c716376cabc

google: dummy commit to trigger Trybot after rebasing

3178b87

Change-Id: Iefbf394e5aa3bc69b5a82ec861b1b4a2b21c941a

google: resolve merge conflict from dummy commit changes

1aa066d

Change-Id: I0f775143be9f66e80b3a0bc0ecf92952f41a8cd1

google-cla bot added cla: no and removed cla: yes labels Dec 2, 2020

gIthuriel closed this Aug 16, 2021



		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if diff := cmp.Diff(*r, serverReq); diff != "" {

google: add ExchangeToken() to run STS exchanges. #444

google: add ExchangeToken() to run STS exchanges. #444

Uh oh!

Conversation

gIthuriel commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 13, 2020

Uh oh!

renkelvin Oct 13, 2020

Choose a reason for hiding this comment

Uh oh!

gopherbot commented Oct 19, 2020

Uh oh!

gopherbot commented Oct 19, 2020

Uh oh!

gopherbot commented Oct 19, 2020

Uh oh!

gopherbot commented Oct 19, 2020

Uh oh!

gopherbot commented Oct 19, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Nov 3, 2020

Uh oh!

gopherbot commented Dec 2, 2020

Uh oh!

gopherbot commented Dec 2, 2020

Uh oh!

google-cla bot commented Dec 2, 2020

Uh oh!

gopherbot commented Dec 2, 2020

Uh oh!

gIthuriel commented Aug 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gIthuriel commented Oct 13, 2020 •

edited

Loading