Skip to content

Conversation

@gIthuriel
Copy link
Contributor

Adds some documentation to existing public structures for third-party authentication.

@google-cla
Copy link

google-cla bot commented Mar 15, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 15, 2021
Change-Id: I30610b306ea5a8c1d7e1fc3e6f151a4449345331
@gIthuriel gIthuriel force-pushed the external-account-documentation branch from 6effc54 to da81792 Compare March 15, 2021 03:32
@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 15, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: da81792) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/301610 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1: Run-TryBot+1 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d6276e1b


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

Change-Id: I763526c33b0a7952ccc205df421d0e2bee39c4f7
@gopherbot
Copy link
Contributor

This PR (HEAD: 9d2d872) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/301610 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 2: Trust+1

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 89cec01) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/301610 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 78072af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/301610 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 4:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Run-TryBot+1 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 4: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: c846ea6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/301610 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301610.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 22, 2021
Adds some documentation to existing public structures for third-party authentication.

Change-Id: I756f5cd5619fbd752c028e99176991139fd45c60
GitHub-Last-Rev: c846ea6
GitHub-Pull-Request: #485
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/301610
Trust: Cody Oss <codyoss@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/301610 has been merged.

@gopherbot gopherbot closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants