Skip to content

Conversation

@akay
Copy link
Contributor

@akay akay commented Apr 14, 2021

@google-cla
Copy link

google-cla bot commented Apr 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 14, 2021
@akay
Copy link
Contributor Author

akay commented Apr 14, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 14, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: e959643) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/310249 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/310249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/310249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/310249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/310249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/310249.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 14, 2021
OAuth APIs: https://develop.battle.net/documentation/battle-net/oauth-apis

Change-Id: I7c10f68c6ef0cb9b77cffa104e71a7198a599c89
GitHub-Last-Rev: e959643
GitHub-Pull-Request: #489
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/310249
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/310249 has been merged.

@gopherbot gopherbot closed this May 14, 2021
@akay akay deleted the patch-1 branch May 14, 2021 16:54
@andig
Copy link
Contributor

andig commented Nov 22, 2021

I'm wondering why new endpoints are accepted here. According to policy:

Policy for new packages

We no longer accept new provider-specific packages in this repo if all they do is add a single endpoint variable. If you just want to add a single endpoint, add it to the pkg.go.dev/golang.org/x/oauth2/endpoints package.

While this is not a new package, it is a new endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants