google/downscope: additional examples #513

Galadros · 2021-08-02T18:41:14Z

Updating examples to match the expected token broker & token consumer paradigm.

…estricted permissions

… example and touching up comment formatting.

…, update examples accordingly, and test for maximum boundary rule violations

…stead run that code inside of Token()

Merging with master to fix some PR oddities for downscoping documentation

gopherbot · 2021-08-02T18:44:29Z

This PR (HEAD: e1c4f01) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/339190 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-04T01:32:25Z

Message from Bassam Ojeil:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-04T02:08:14Z

Message from Bassam Ojeil:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-04T02:26:13Z

Message from Leo Siracusa:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-04T23:57:23Z

Message from Bassam Ojeil:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-05T03:33:43Z

Message from Leo Siracusa:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-05T17:29:34Z

This PR (HEAD: b74b094) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/339190 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-05T17:32:15Z

Message from Patrick Jones:

Patch Set 3:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-05T17:34:53Z

This PR (HEAD: 6338e2b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/339190 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-05T17:40:11Z

Message from Leo Siracusa:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-05T17:45:25Z

This PR (HEAD: c56d618) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/339190 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-05T17:48:00Z

Message from Patrick Jones:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-05T18:01:07Z

Message from Bassam Ojeil:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-06T19:12:07Z

Message from Patrick Jones:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-09T18:24:26Z

Message from Cody Oss:

Patch Set 6: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-09T18:29:27Z

Message from Go Bot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-09T18:29:28Z

Message from Go Bot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-09T18:29:29Z

Message from Go Bot:

Patch Set 6: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-09T20:35:47Z

This PR (HEAD: 2149795) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/339190 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-09T20:48:35Z

Message from Patrick Jones:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:46:00Z

Message from Leo Siracusa:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:46:01Z

Message from Cody Oss:

Patch Set 7: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:46:02Z

Message from Go Bot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:46:02Z

Message from Cody Oss:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

Updating examples to match the expected token broker & token consumer paradigm. Change-Id: I9f6474e6d433e544dc92d8b1595e9538a5266043 GitHub-Last-Rev: 2149795 GitHub-Pull-Request: #513 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/339190 Reviewed-by: Leo Siracusa <leosiracusa@google.com> Reviewed-by: Cody Oss <codyoss@google.com> Trust: Cody Oss <codyoss@google.com> Trust: Chris Broadfoot <cbro@golang.org> Run-TryBot: Cody Oss <codyoss@google.com> TryBot-Result: Go Bot <gobot@golang.org>

gopherbot · 2021-08-10T18:40:13Z

Message from Chris Broadfoot:

Patch Set 7: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/339190.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T18:43:47Z

This PR is being closed because golang.org/cl/339190 has been merged.

gIthuriel and others added 25 commits June 9, 2021 10:46

oauth2/google: implement support for token downscoping to allow for r…

a8e26b9

…estricted permissions

First set of comment changes.

52684dc

Add some validity testing for AccessBoundaryRules and add documentation.

eb57311

Add exmaple showing how NewTokenSource should be called.

add9801

go fmt

e035bf9

downscope: make changes related to comments, including adding another…

69736ff

… example and touching up comment formatting.

downscope: update comment formatting

be467ee

downscope: add some context to returned error

c4c64d5

downscope: move example files to a separate file & package

776a9ed

downscope: minor tweaks

b594a60

downscope: fixing nits and renaming

cbbc506

downscope: refactor main functionality into a method on a tokenSource…

1d9ea0c

…, update examples accordingly, and test for maximum boundary rule violations

downscope: fix grammar and punctuation.

a362f28

downscope: further updates and nits

304d28b

downscope: refactor some code to remove an extraneous function and in…

1024258

…stead run that code inside of Token()

downscope: change return type of NewTokenSource

1888dba

downscope: fix some nits

fec7137

downscope: move validation checks

941cf10

downscope: update documentation

c976479

Merge pull request #1 from Galadros/downscopeDocumentation

d921d8f

Merging with master to fix some PR oddities for downscoping documentation

Removed some code that's not yet finished

e4ec8cd

Merge branch 'master' into master

3045b9f

downscope: documentation tweaks

0bd54f5

Merge branch 'master' of github.com:Galadros/oauth2

e4caaa9

downscope: add new examples and update existing ones.

e1c4f01

google-cla bot added the cla: yes label Aug 2, 2021

Galadros changed the title ~~downscope: additional examples~~ google/downscope: additional examples Aug 4, 2021

more nits

b74b094

Merge branch 'golang:master' into master

387bb65

Merge branch 'master' into downscope-example-additions

6338e2b

Removed extraneous newline.

c56d618

Removed tokenconsumer example file; will add the examples elsewhere.

2149795

gopherbot closed this Aug 10, 2021

google/downscope: additional examples #513

google/downscope: additional examples #513

Uh oh!

Conversation

Galadros commented Aug 2, 2021

Uh oh!

gopherbot commented Aug 2, 2021

Uh oh!

gopherbot commented Aug 4, 2021

Uh oh!

gopherbot commented Aug 4, 2021

Uh oh!

gopherbot commented Aug 4, 2021

Uh oh!

gopherbot commented Aug 4, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 5, 2021

Uh oh!

gopherbot commented Aug 6, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 9, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

gopherbot commented Aug 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants