Skip to content

gopls/internal/golang: fall back when ( is not a dynamic function call#617

Open
manimz wants to merge 1 commit intogolang:masterfrom
manimz:impl-nondynamic-call
Open

gopls/internal/golang: fall back when ( is not a dynamic function call#617
manimz wants to merge 1 commit intogolang:masterfrom
manimz:impl-nondynamic-call

Conversation

@manimz
Copy link

@manimz manimz commented Feb 25, 2026

When implementation is requested at the "(" paren of a call, implFuncs
first checks whether the call is dynamic. For calls that are not dynamic
function calls (for example, method calls), that check fails.

Instead of returning a hard error, return errNotHandled so the request
falls back to the regular method-set implementation path.

This restores the fallback behavior that regressed in
25a90be.

Fixes golang/go#77784

When implementation is requested at the "(" paren of a call, implFuncs
first checks whether the call is dynamic. For calls that are not dynamic
function calls (for example, method calls), that check fails.

Instead of returning a hard error, return errNotHandled so the request
falls back to the regular method-set implementation path.

This restores the fallback behavior that regressed in
25a90be.

Fixes golang/go#77784
@manimz manimz force-pushed the impl-nondynamic-call branch from 483692b to d082b3c Compare February 25, 2026 05:29
@gopherbot
Copy link
Contributor

This PR (HEAD: d082b3c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/748740.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/748740.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/748740.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/gopls: implementation at ( paren should fall back for non-dynamic calls

2 participants