gopls/internal/golang: fall back when ( is not a dynamic function call#617
gopls/internal/golang: fall back when ( is not a dynamic function call#617manimz wants to merge 1 commit intogolang:masterfrom
Conversation
When implementation is requested at the "(" paren of a call, implFuncs
first checks whether the call is dynamic. For calls that are not dynamic
function calls (for example, method calls), that check fails.
Instead of returning a hard error, return errNotHandled so the request
falls back to the regular method-set implementation path.
This restores the fallback behavior that regressed in
25a90be.
Fixes golang/go#77784
483692b to
d082b3c
Compare
|
This PR (HEAD: d082b3c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/748740. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/748740. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/748740. |
When implementation is requested at the "(" paren of a call, implFuncs
first checks whether the call is dynamic. For calls that are not dynamic
function calls (for example, method calls), that check fails.
Instead of returning a hard error, return errNotHandled so the request
falls back to the regular method-set implementation path.
This restores the fallback behavior that regressed in
25a90be.
Fixes golang/go#77784