package.json: fix spelling for generateTestForPackage #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dekimsey wants to merge 1 commit into golang:master from dekimsey:patch-1

Contributor

dekimsey commented Feb 1, 2022

Minor spelling fix on the settings description for generateTestForPackage.


          Fix spelling in generateTestForPackage description

66c2847

Collaborator

gopherbot commented Feb 1, 2022

This PR (HEAD: 66c2847) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/382174 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Collaborator

gopherbot commented Feb 1, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Feb 1, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Feb 1, 2022

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4c8f291b-d406-405c-84b7-d97798515a67

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Feb 1, 2022

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/4c8f291b-d406-405c-84b7-d97798515a67

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from Hyang-Ah Hana Kim:

Uploaded patch set 2: Trust+1.

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/845f07e1-c30a-4828-ad9c-eabe5599a408

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/845f07e1-c30a-4828-ad9c-eabe5599a408

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from Hyang-Ah Hana Kim:

Uploaded patch set 4: Run-TryBot+1.

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/107fd7aa-33c4-454d-a0d6-087bbaa6c6be

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 1, 2022

Message from kokoro:

Patch Set 4: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/107fd7aa-33c4-454d-a0d6-087bbaa6c6be

Please don’t reply on this GitHub thread. Visit golang.org/cl/382174.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          package.json: fix spelling for generateTestForPackage

Originally from #2045

Co-authored-by: Daniel Kimsey <90741+dekimsey@users.noreply.github.com>
Change-Id: If8ead56fd241ba61bb8f757cdb910f57922f8079
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/388954
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>

Collaborator

gopherbot commented Mar 2, 2022

This PR is being closed because golang.org/cl/382174 has been abandoned.

obsolete by https://go-review.googlesource.com/c/vscode-go/+/388954

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet