Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2025

Bumps github.com/go-critic/go-critic from 0.13.0 to 0.14.0.

Release notes

Sourced from github.com/go-critic/go-critic's releases.

v0.14.0

What's Changed

New Contributors

Full Changelog: go-critic/go-critic@v0.13.0...v0.14.0

Commits
  • 26869a4 deps: bump golang.org/x/tools from 0.35.0 to 0.36.0 (#1500)
  • 5beeab6 ci: bump actions/setup-go from 5 to 6 (#1503)
  • 188b8b0 ci: bump actions/checkout from 4 to 5 (#1501)
  • 24d5174 deps: bump golang.org/x/tools from 0.34.0 to 0.35.0 (#1498)
  • db2ec6f deps: bump golang.org/x/tools from 0.33.0 to 0.34.0 (#1492)
  • dfe69b7 docs/readme: add Homebrew install instructions (#1491)
  • cf715f9 auto generate doc [bot]
  • cafe067 checker: add zeroByteRepeat for avoiding bytes.Repeat([]byte{0}, x) (#1488)
  • 58947df deps: bump golang.org/x/tools from 0.32.0 to 0.33.0 (#1489)
  • ac47943 checker/badCond: rhs should be also check for safe expr (#1486)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Oct 15, 2025
@ldez ldez added the linter: update version Update version of linter label Oct 15, 2025
@ldez ldez added this to the unreleased milestone Oct 15, 2025
@ldez ldez self-requested a review October 15, 2025 12:09
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-critic/go-critic-0.14.0 branch from 66c00e2 to e844622 Compare October 15, 2025 13:06
Bumps [github.com/go-critic/go-critic](https://github.com/go-critic/go-critic) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/go-critic/go-critic/releases)
- [Commits](go-critic/go-critic@v0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: github.com/go-critic/go-critic
  dependency-version: 0.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-critic/go-critic-0.14.0 branch from e844622 to 38fc914 Compare October 15, 2025 13:07
@ldez ldez merged commit f61b811 into main Oct 15, 2025
18 of 19 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/go-critic/go-critic-0.14.0 branch October 15, 2025 14:42
@ldez ldez modified the milestones: unreleased, v2.6 Oct 29, 2025
@ptman
Copy link

ptman commented Oct 30, 2025

Did you test gocritic? Started failing:

WARN [runner] Can't run linter goanalysis_metalinter: goanalysis_metalinter: gocritic: package "main" (isInitialPkg: true, needAnalyzeSource: true): runtime error: slice bounds out of range [2:1] 
ERRO Running error: can't run linter goanalysis_metalinter
goanalysis_metalinter: gocritic: package "main" (isInitialPkg: true, needAnalyzeSource: true): runtime error: slice bounds out of range [2:1] 

go-critic/go-critic#1514

@bombsimon
Copy link
Member

bombsimon commented Oct 30, 2025

Yes, all linters are tested in our pipeline. This doesn't seem to affect all codebases, working fine on golangci-lint:

› golangci-lint version
golangci-lint has version 2.6.0 built with go1.25.3 from fb09c371 on 2025-10-29T19:41:04Z

› golangci-lint run --default none --enable gocritic
0 issues.

If possible I think it would be good to add a repro to go-critic/go-critic#1514

@ldez
Copy link
Member

ldez commented Oct 30, 2025

@ptman can you open a dedicated issue (with a reproducible example)?

@ldez
Copy link
Member

ldez commented Oct 30, 2025

#6163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants